Re: [PATCH weston] terminal: Fix crash due to race condition in init

2017-02-17 Thread Mike Blumenkrantz
Hi, Reverting this causes a 100% reproducible crash on startup in one of my CI tests for weston-terminal. Here is some of the debugging info: Program terminated with signal SIGSEGV, Segmentation fault. #0 0x0040ab93 in handle_char (terminal=0x6348a0, utf8=...) at clients/terminal.c:1991

Re: [PATCH weston] terminal: Fix crash due to race condition in init

2016-09-09 Thread Quentin Glidic
On 09/09/2016 19:02, Derek Foreman wrote: On 31/08/16 05:56 PM, Quentin Glidic wrote: On 30/08/2016 04:07, Yong Bakos wrote: On Aug 29, 2016, at 4:28 PM, Bryce Harrington wrote: weston-terminal intermittently crashes on startup. This occurs because some parameters in the weston_terminal str

Re: [PATCH weston] terminal: Fix crash due to race condition in init

2016-09-09 Thread Derek Foreman
On 31/08/16 05:56 PM, Quentin Glidic wrote: > On 30/08/2016 04:07, Yong Bakos wrote: >> On Aug 29, 2016, at 4:28 PM, Bryce Harrington >> wrote: >>> >>> weston-terminal intermittently crashes on startup. This occurs because >>> some parameters in the weston_terminal structure such as data_pitch, >

Re: [PATCH weston] terminal: Fix crash due to race condition in init

2016-08-31 Thread Quentin Glidic
On 30/08/2016 04:07, Yong Bakos wrote: On Aug 29, 2016, at 4:28 PM, Bryce Harrington wrote: weston-terminal intermittently crashes on startup. This occurs because some parameters in the weston_terminal structure such as data_pitch, don't get set to non-zero until the resize_handler() callback

Re: [PATCH weston] terminal: Fix crash due to race condition in init

2016-08-29 Thread Yong Bakos
On Aug 29, 2016, at 4:28 PM, Bryce Harrington wrote: > > weston-terminal intermittently crashes on startup. This occurs because > some parameters in the weston_terminal structure such as data_pitch, > don't get set to non-zero until the resize_handler() callback gets > triggered. That callback

[PATCH weston] terminal: Fix crash due to race condition in init

2016-08-29 Thread Bryce Harrington
weston-terminal intermittently crashes on startup. This occurs because some parameters in the weston_terminal structure such as data_pitch, don't get set to non-zero until the resize_handler() callback gets triggered. That callback makes a call to terminal_resize_cells(), to calculate the proper