Re: [PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

2014-08-28 Thread Ryo Munakata
I found another one in multi-resouce. Patch sent. Thanks. On Thu, 28 Aug 2014 11:59:43 +0300 Pekka Paalanen wrote: > On Tue, 26 Aug 2014 21:25:22 +0200 > "Nils Chr. Brause" wrote: > > > Since wl_display_get_fd() doesn't have any side effects, this is truly > > useless. > > > > Reviewed-by: N

Re: [PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

2014-08-28 Thread Pekka Paalanen
On Tue, 26 Aug 2014 21:25:22 +0200 "Nils Chr. Brause" wrote: > Since wl_display_get_fd() doesn't have any side effects, this is truly > useless. > > Reviewed-by: Nils Chr. Brause > > > > On Tue, Aug 26, 2014 at 2:59 PM, Ryo Munakata wrote: > > > --- > > clients/simple-shm.c | 2 -- > > 1

Re: [PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

2014-08-26 Thread Nils Chr. Brause
Since wl_display_get_fd() doesn't have any side effects, this is truly useless. Reviewed-by: Nils Chr. Brause On Tue, Aug 26, 2014 at 2:59 PM, Ryo Munakata wrote: > --- > clients/simple-shm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/clients/simple-shm.c b/clients/simple-shm

[PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

2014-08-26 Thread Ryo Munakata
--- clients/simple-shm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/simple-shm.c b/clients/simple-shm.c index b1c311f..c1cb386 100644 --- a/clients/simple-shm.c +++ b/clients/simple-shm.c @@ -393,8 +393,6 @@ create_display(void) exit(1); } - wl_dis