Re: [PATCH weston] shell: fix segfault in fullscreen binding

2014-06-25 Thread Jasper St. Pierre
Well, I removed recommended_output in that patch, because it became unnecessary. The set to NULL makes no sense to me either. You should just be able to do a one-line patch: +shsurf->fullscreen_output = shsurf->output; I don't see any need for anything more fancy. I'd also add a comment alon

Re: [PATCH weston] shell: fix segfault in fullscreen binding

2014-06-24 Thread Boyan Ding
On Tue, 2014-06-24 at 21:40 -0700, Jason Ekstrand wrote: > Yes we should fix this. I have one question below. Actually I'm not very sure about that either, maybe we should ask @Jasper for suggestion. > > On Sat, Jun 7, 2014 at 2:40 AM, Boyan Ding wrote: > Commit 9aa8ce69 'shell: Don't u

Re: [PATCH weston] shell: fix segfault in fullscreen binding

2014-06-24 Thread Jason Ekstrand
Yes we should fix this. I have one question below. On Sat, Jun 7, 2014 at 2:40 AM, Boyan Ding wrote: > Commit 9aa8ce69 'shell: Don't use the helper methods in xdg_shell > implementations' forgot to set shsurf->fullscreen_optput in > fullscreen_binding(), causing weston to segfault when fullscr

[PATCH weston] shell: fix segfault in fullscreen binding

2014-06-07 Thread Boyan Ding
Commit 9aa8ce69 'shell: Don't use the helper methods in xdg_shell implementations' forgot to set shsurf->fullscreen_optput in fullscreen_binding(), causing weston to segfault when fullscreen with the mod + shift + f binding. This patch fixed that issue. --- desktop-shell/shell.c | 6 ++ 1 file