Re: [PATCH weston] input: Fix weston_seat_init_keyboard() error path

2014-02-01 Thread Kristian Høgsberg
On Fri, Jan 31, 2014 at 05:35:45PM +0200, Ander Conselvan de Oliveira wrote: > The pointer seat->keyboard was set before some possible error returns. > That pointer was left unchanged in case of failure, pointing to an > uninitialized keyboard struct (that was also leaked). If a client sent > a wl_

[PATCH weston] input: Fix weston_seat_init_keyboard() error path

2014-01-31 Thread Ander Conselvan de Oliveira
The pointer seat->keyboard was set before some possible error returns. That pointer was left unchanged in case of failure, pointing to an uninitialized keyboard struct (that was also leaked). If a client sent a wl_seat::get_keyboard request, that would cause Weston to crash. Fix this by setting th