Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-04-08 Thread Pekka Paalanen
On Fri, 3 Apr 2015 07:05:23 +0200 Manuel Bachmann wrote: > From: Manuel Bachmann > > Some DRI drivers, including VMware vmwgfx, do not support > calling eglQueryString() with a EGL_NO_DISPLAY parameter. > Just as we do in gl_renderer_supports(), which returns 0 > but does not fail in this case

[PATCH weston] gl-renderer: fix EGL initialization steps

2015-04-02 Thread Manuel Bachmann
From: Manuel Bachmann Some DRI drivers, including VMware vmwgfx, do not support calling eglQueryString() with a EGL_NO_DISPLAY parameter. Just as we do in gl_renderer_supports(), which returns 0 but does not fail in this case, do not fail in gl_renderer_setup_egl_extensions(). With some versions

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-04-02 Thread Manuel Bachmann
Agreed ! I am going send the patch again, same name ("gl-renderer: fix EGL initialization steps") but modified in this sense and with another commit message, Regards, Manuel 2015-04-02 11:51 GMT+02:00 Pekka Paalanen : > On Mon, 30 Mar 2015 21:48:32 +0200 > Manuel Bachmann wrote: > > > OK. Foun

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-04-02 Thread Pekka Paalanen
On Mon, 30 Mar 2015 21:48:32 +0200 Manuel Bachmann wrote: > OK. Found it, thanks to your hint, Daniel. > > This version of Mesa (10.1.3) does not feature these extensions. > > They were added here : > http://cgit.freedesktop.org/mesa/mesa/commit/src/egl/main/eglglobals.c?id=468cc866b4b308cee404

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Manuel Bachmann
OK. Found it, thanks to your hint, Daniel. This version of Mesa (10.1.3) does not feature these extensions. They were added here : http://cgit.freedesktop.org/mesa/mesa/commit/src/egl/main/eglglobals.c?id=468cc866b4b308cee40470f06b31002c6c56da96 Considering that recent distributions, such as Ubu

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Manuel Bachmann
Hi Daniel, and thanks, "What is the complete client extension string on that platform?" It is simply "EGL_EXT_client_extensions". Here are the details : kernel 3.13.0 - Mesa 10.1.3 (built with "with-egl-platforms=wayland,x11,drm") - kernel module is "i915" - EGL is : 1.4 (DRI2) - GL vendor is :

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Daniel Stone
Hi, On 30 March 2015 at 17:38, Manuel Bachmann wrote: > "You removed the early return here... > ...which means this check may be accessing NULL extensions, no?" > > You are right ! Sorry for that, did not even look at the #ifdef, will rework > this part. Apart from the configless_context damage,

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Manuel Bachmann
"You removed the early return here... ...which means this check may be accessing NULL extensions, no?" You are right ! Sorry for that, did not even look at the #ifdef, will rework this part. "You do want to keep the -1 return as fatal here. gl_renderer_supports() should already return 0 meaning "

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Pekka Paalanen
On Sun, 29 Mar 2015 05:03:09 +0200 Manuel Bachmann wrote: > From: Manuel Bachmann > > We should not prevent gl-renderer to initalize if client > extensions were not found. Practically, this prevented > Weston from running with GL on i915 DRI platforms. > > Some DRI drivers, including VMware vm

[PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-28 Thread Manuel Bachmann
From: Manuel Bachmann We should not prevent gl-renderer to initalize if client extensions were not found. Practically, this prevented Weston from running with GL on i915 DRI platforms. Some DRI drivers, including VMware vmwgfx, do not support calling eglQueryString() with a EGL_NO_DISPLAY parame