Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-12-01 Thread Daniel Stone
Hi all, On 29 November 2017 at 18:49, Arnaud Vrac wrote: > this patch is Reviewed-by: Arnaud Vrac I've pushed this with a pile of tags now. Thanks everyone! Cheers, Daniel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lis

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-11-29 Thread Arnaud Vrac
Hi, this patch is Reviewed-by: Arnaud Vrac Nicolas made some changes to the waylandsink element in gstreamer [1] to better support pitfalls of the SHM protocol. With this patch and the one I posted earlier today, gstreamer git now works perfectly with weston when using SHM, even when using YUV f

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-31 Thread Nicolas Dufresne
Hi Daniel, Le vendredi 06 octobre 2017 à 19:03 +0100, Daniel Stone a écrit : > Hi Pekka, > > On 6 October 2017 at 08:41, Pekka Paalanen > wrote: > > I feel the commit message needs more rationale on why this is the > > correct fix before I can give a R-b. > > Fair enough. > > > How confident a

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-09 Thread Vincent ABRIOU
I resent it (issue in the mailing list address) Hi Daniel, Your patch is good to me. On 10/09/2017 09:15 AM, Pekka Paalanen wrote: > Hi Nicolas and Daniel, > > excellent comments, I think we just need a summary of them in the > commit message and we could land the original patch. If you want t

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-09 Thread Fabien Lahoudere
Hello I test this patch and it fixes my problem. Thanks On Thu, 2017-10-05 at 15:36 +0100, Daniel Stone wrote: > Multi-plane sub-sampled textures have partial width/height, e.g. > YUV420/I420 has a full-size Y plane, followed by a half-width/height U > plane, and a half-width/height V plane. >

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-09 Thread Pekka Paalanen
Hi Nicolas and Daniel, excellent comments, I think we just need a summary of them in the commit message and we could land the original patch. If you want to squash in the glTexSubImage2D fix, that would be fine as well. On Fri, 06 Oct 2017 15:06:55 -0400 Nicolas Dufresne wrote: > Hi Daniel, >

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-06 Thread Daniel Stone
Hi Pekka, On 6 October 2017 at 08:41, Pekka Paalanen wrote: > I feel the commit message needs more rationale on why this is the > correct fix before I can give a R-b. Fair enough. > How confident are we that waylandsink and the others (which?) are > correct and did not have an unintended code c

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-06 Thread Pekka Paalanen
On Thu, 5 Oct 2017 15:36:08 +0100 Daniel Stone wrote: > Multi-plane sub-sampled textures have partial width/height, e.g. > YUV420/I420 has a full-size Y plane, followed by a half-width/height U > plane, and a half-width/height V plane. > > zwp_linux_dmabuf_v1 allows clients to pass an explicit

[PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-05 Thread Daniel Stone
Multi-plane sub-sampled textures have partial width/height, e.g. YUV420/I420 has a full-size Y plane, followed by a half-width/height U plane, and a half-width/height V plane. zwp_linux_dmabuf_v1 allows clients to pass an explicit pitch for each plane, but for wl_shm this must be inferred. gl-rend