Re: [PATCH weston] don't attempt to start input method if path is empty

2015-06-11 Thread Pekka Paalanen
On Tue, 9 Jun 2015 20:28:06 + Murray Calavera wrote: > This allows a user to explicitly disable the input > method by setting path to blank; > > Signed-off-by: Murray Calavera > --- > src/text-backend.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/text-backend.c b/src/

Re: [PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Pekka Paalanen
On Wed, 10 Jun 2015 08:48:01 +1000 Peter Hutterer wrote: > On Tue, Jun 09, 2015 at 03:00:26PM -0700, Jon A. Cruz wrote: > > Instead of a full strcmp against an empty string, could we just check > > the first char? > > > > if (!text_backend->input_method.path[0]) > > does this really gain us

Re: [PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Peter Hutterer
On Tue, Jun 09, 2015 at 03:00:26PM -0700, Jon A. Cruz wrote: > Instead of a full strcmp against an empty string, could we just check > the first char? > > if (!text_backend->input_method.path[0]) does this really gain us anything worthwhile? Cheers, Peter > On 06/09/2015 01:28 PM, Murray

Re: [PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Jon A. Cruz
Instead of a full strcmp against an empty string, could we just check the first char? if (!text_backend->input_method.path[0]) On 06/09/2015 01:28 PM, Murray Calavera wrote: > This allows a user to explicitly disable the input > method by setting path to blank; > > Signed-off-by: Murray Cal

[PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Murray Calavera
This allows a user to explicitly disable the input method by setting path to blank; Signed-off-by: Murray Calavera --- src/text-backend.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/text-backend.c b/src/text-backend.c index 64a3c1b..3c349d4 100644 --- a/src/text-backend.c +++ b/sr