Re: [PATCH weston] desktop-shell: NULL check whether a popup parent is a shell surface

2015-10-07 Thread Derek Foreman
On 07/10/15 01:44 AM, Jonas Ådahl wrote: > get_shell_surface(parent) may return NULL if the client passed a > unassigned wl_surface or a wl_surface with a non-shell surface role > (such as cursor role). > > https://bugs.freedesktop.org/show_bug.cgi?id=92316 > > Signed-off-by: Jonas Ådahl Looks

Re: [PATCH weston] desktop-shell: NULL check whether a popup parent is a shell surface

2015-10-06 Thread Olivier Fourdan
> get_shell_surface(parent) may return NULL if the client passed a > unassigned wl_surface or a wl_surface with a non-shell surface role > (such as cursor role). > > https://bugs.freedesktop.org/show_bug.cgi?id=92316 > > Signed-off-by: Jonas Ådahl Tested-by: Olivier Fourdan Works for me :-)

[PATCH weston] desktop-shell: NULL check whether a popup parent is a shell surface

2015-10-06 Thread Jonas Ådahl
get_shell_surface(parent) may return NULL if the client passed a unassigned wl_surface or a wl_surface with a non-shell surface role (such as cursor role). https://bugs.freedesktop.org/show_bug.cgi?id=92316 Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 5 +++-- 1 file changed, 3 insert