Re: [PATCH weston] desktop-shell: Fail if get_xdg_surface is called on an xdg_surface

2015-02-05 Thread Jasper St. Pierre
On Thu, Feb 5, 2015 at 5:11 AM, Daniel Stone wrote: > Hi, > > On 5 February 2015 at 08:58, Jonas Ådahl wrote: > > If a client calls xdg_shell.get_xdg_surface on a surface that is already > > an xdg_surface wold, prior to this patch, succeed, but cause weston to > > crash later when trying to con

Re: [PATCH weston] desktop-shell: Fail if get_xdg_surface is called on an xdg_surface

2015-02-05 Thread Bryce Harrington
On Thu, Feb 05, 2015 at 04:58:05PM +0800, Jonas Ådahl wrote: > If a client calls xdg_shell.get_xdg_surface on a surface that is already > an xdg_surface wold, prior to this patch, succeed, but cause weston to s/wold/would/ > crash later when trying to configure. This patch instead sends a role >

Re: [PATCH weston] desktop-shell: Fail if get_xdg_surface is called on an xdg_surface

2015-02-05 Thread Jonas Ådahl
On Thu, Feb 05, 2015 at 01:11:54PM +, Daniel Stone wrote: > Hi, > > On 5 February 2015 at 08:58, Jonas Ådahl wrote: > > If a client calls xdg_shell.get_xdg_surface on a surface that is already > > an xdg_surface wold, prior to this patch, succeed, but cause weston to > > crash later when tryi

Re: [PATCH weston] desktop-shell: Fail if get_xdg_surface is called on an xdg_surface

2015-02-05 Thread Daniel Stone
Hi, On 5 February 2015 at 08:58, Jonas Ådahl wrote: > If a client calls xdg_shell.get_xdg_surface on a surface that is already > an xdg_surface wold, prior to this patch, succeed, but cause weston to > crash later when trying to configure. This patch instead sends a role > error to the client com

[PATCH weston] desktop-shell: Fail if get_xdg_surface is called on an xdg_surface

2015-02-05 Thread Jonas Ådahl
If a client calls xdg_shell.get_xdg_surface on a surface that is already an xdg_surface wold, prior to this patch, succeed, but cause weston to crash later when trying to configure. This patch instead sends a role error to the client complaining that it already is an xdg_surface. Note that .._set_