Re: [PATCH weston] data-device: Implement DnD progress notification

2015-09-30 Thread Michael Catanzaro
Reviewed-by: Michael Catanzaro Looks mostly good to me. The only problem I see is that you've left stale conditionals in both data_offer_accept and data_offer_receive, which can't be hit anymore since you added the bails up above. Be sure that fd gets freed in data_offer_receive when it's not sen

[PATCH weston] data-device: Implement DnD progress notification

2015-09-30 Thread Carlos Garnacho
Weston now sends wl_data_source.drop_performed and .drag_finished in order to notify about the different phases of DnD. wl_data_source.cancelled is also used as mentioned in the docs, being emitted also on DnD when the operation is meant to fail (eg. source and dest didn't agree on a mimetype). T