Re: [PATCH weston] compositor: rebuild the global list if we've removed a surface from it

2013-07-08 Thread Rob Bradford
Hi Pekka, You raise a good point. I don't think the increase in complexity is worth it - we have good way to construct a surface list from the layers (and we do it at the start of every frame) anyway: I think it's nice that the management of this cache is really encapsulated in a single place. Ro

Re: [PATCH weston] compositor: rebuild the global list if we've removed a surface from it

2013-07-06 Thread Pekka Paalanen
On Wed, 26 Jun 2013 18:08:46 +0100 Rob Bradford wrote: > From: Rob Bradford > > The list of surfaces used by weston_compositor_pick_surface() is > maintained in list of surfaces stored on the compositor. This list is > generated from the surfaces across all the layers using > weston_compositor_

Re: [PATCH weston] compositor: rebuild the global list if we've removed a surface from it

2013-07-05 Thread Kristian Høgsberg
On Wed, Jun 26, 2013 at 06:08:46PM +0100, Rob Bradford wrote: > From: Rob Bradford > > The list of surfaces used by weston_compositor_pick_surface() is > maintained in list of surfaces stored on the compositor. This list is > generated from the surfaces across all the layers using > weston_compos

Re: [PATCH weston] compositor: rebuild the global list if we've removed a surface from it

2013-06-27 Thread Hardening
Le 26/06/2013 19:36, Eoff, Ullysses A a écrit : This patch also fixed https://bugs.freedesktop.org/show_bug.cgi?id=66173 Confirmed here too (my backtrace was a little different in #66173). Regards. ___ wayland-devel mailing list wayland-devel@list

RE: [PATCH weston] compositor: rebuild the global list if we've removed a surface from it

2013-06-26 Thread Eoff, Ullysses A
> Ullysses A > Sent: Wednesday, June 26, 2013 10:31 AM > To: Bradford, Robert; wayland-devel@lists.freedesktop.org > Cc: Rob Bradford > Subject: RE: [PATCH weston] compositor: rebuild the global list if we've > removed a surface from it > > Confirmed. This pa

RE: [PATCH weston] compositor: rebuild the global list if we've removed a surface from it

2013-06-26 Thread Eoff, Ullysses A
gt; To: wayland-devel@lists.freedesktop.org > Cc: Rob Bradford > Subject: [PATCH weston] compositor: rebuild the global list if we've removed > a surface from it > > From: Rob Bradford > > The list of surfaces used by weston_compositor_pick_surface() is > maintained in list

[PATCH weston] compositor: rebuild the global list if we've removed a surface from it

2013-06-26 Thread Rob Bradford
From: Rob Bradford The list of surfaces used by weston_compositor_pick_surface() is maintained in list of surfaces stored on the compositor. This list is generated from the surfaces across all the layers using weston_compositor_build_surface_list. When destroying a surface the surface is "unmapp