Re: [PATCH weston] compositor: init the layer_link after removing it

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 04, 2013 at 11:24:42PM +0200, Giulio Camuffo wrote: > Nowhere in Weston. But i thought it was the accepted policy to not have > around links not initted. But if it not it's no problem. No, it depends on the link. In some cases we want to be able to remove a link without worrying about

Re: [PATCH weston] compositor: init the layer_link after removing it

2013-04-04 Thread Giulio Camuffo
Nowhere in Weston. But i thought it was the accepted policy to not have around links not initted. But if it not it's no problem. Giulio 2013/4/4 Kristian Høgsberg > On Thu, Apr 04, 2013 at 11:08:22PM +0200, Giulio Camuffo wrote: > > --- > > src/compositor.c | 1 + > > 1 file changed, 1 insert

Re: [PATCH weston] compositor: init the layer_link after removing it

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 04, 2013 at 11:08:22PM +0200, Giulio Camuffo wrote: > --- > src/compositor.c | 1 + > 1 file changed, 1 insertion(+) When is this needed? I don't think we rely on layer_link being valid when a surface is not mapped (not in any layer). Kristian > diff --git a/src/compositor.c b/src/

[PATCH weston] compositor: init the layer_link after removing it

2013-04-04 Thread Giulio Camuffo
--- src/compositor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compositor.c b/src/compositor.c index 3645b04..88f083c 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -977,6 +977,7 @@ weston_surface_unmap(struct weston_surface *surface) weston_surface_damage_below(surf