Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-27 Thread Kristian Høgsberg
On Thu, Sep 27, 2012 at 9:24 AM, Tiago Vignatti wrote: > On 09/26/2012 07:26 PM, Kristian Høgsberg wrote: >> >> >>> Maybe we should special-case the forking clients and get the return >>> value from the fork() call, i.e the pid now? >> >> >> Yeah, I think that's the way to go... I'm just wondering

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-27 Thread Tiago Vignatti
On 09/26/2012 07:26 PM, Kristian Høgsberg wrote: Maybe we should special-case the forking clients and get the return value from the fork() call, i.e the pid now? Yeah, I think that's the way to go... I'm just wondering if we should add a wl_client_set_credentials() or just work around it in w

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-26 Thread Kristian Høgsberg
On Wed, Sep 26, 2012 at 04:24:56PM +0300, Tiago Vignatti wrote: > On 09/25/2012 06:19 PM, Kristian Høgsberg wrote: > >On Tue, Sep 25, 2012 at 05:54:40PM +0300, Tiago Vignatti wrote: > >> > >>BTW (a bit related with this) to solve part of the Bug 53679, the > >>way we're using socketpair_cloexec to

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-26 Thread Tiago Vignatti
On 09/25/2012 06:19 PM, Kristian Høgsberg wrote: On Tue, Sep 25, 2012 at 05:54:40PM +0300, Tiago Vignatti wrote: BTW (a bit related with this) to solve part of the Bug 53679, the way we're using socketpair_cloexec to create the client socket and later get its credentials in wl_client_create is

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-25 Thread Kristian Høgsberg
On Tue, Sep 25, 2012 at 05:54:40PM +0300, Tiago Vignatti wrote: > On 09/25/2012 05:13 PM, Kristian Høgsberg wrote: > >On Tue, Sep 25, 2012 at 01:52:43PM +0300, Tiago Vignatti wrote: > >>It's a quick fix in opposition of the lack of the two-stage module init. > >>Effectively it fix: > >> > >> ht

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-25 Thread Tiago Vignatti
On 09/25/2012 05:13 PM, Kristian Høgsberg wrote: On Tue, Sep 25, 2012 at 01:52:43PM +0300, Tiago Vignatti wrote: It's a quick fix in opposition of the lack of the two-stage module init. Effectively it fix: https://bugs.freedesktop.org/show_bug.cgi?id=55259 No, the command line modules ar

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-25 Thread Kristian Høgsberg
On Tue, Sep 25, 2012 at 01:52:43PM +0300, Tiago Vignatti wrote: > It's a quick fix in opposition of the lack of the two-stage module init. > Effectively it fix: > > https://bugs.freedesktop.org/show_bug.cgi?id=55259 No, the command line modules are supposed to load after the config file modul

[PATCH weston] compositor: Load shell plugin after option modules

2012-09-25 Thread Tiago Vignatti
It's a quick fix in opposition of the lack of the two-stage module init. Effectively it fix: https://bugs.freedesktop.org/show_bug.cgi?id=55259 Signed-off-by: Tiago Vignatti --- src/compositor.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/sr