Re: [PATCH weston] compositor: Fix rendering with shm transformed buffers

2012-11-30 Thread Kristian Høgsberg
On Wed, Nov 28, 2012 at 05:10:26PM +0200, Ander Conselvan de Oliveira wrote: > The implementation of buffer transformation didn't handle transformed > shm buffers properly. The partial texture upload was broken since the > damage is in surface coordinates that don't necessarily match the > buffer's

Re: [PATCH weston] compositor: Fix rendering with shm transformed buffers

2012-11-29 Thread Rob Bradford
> Say you have a 500x250 surface, but its buffer is rotated 90 degrees, so > that it is 250x500. If the surface damage is the rectangle defined by the > points (10, 20) and (40, 50), we would convert both coordinates and have > (230,10) and (200,40). This does define a rectangle in the buffer, but

Re: [PATCH weston] compositor: Fix rendering with shm transformed buffers

2012-11-29 Thread Ander Conselvan de Oliveira
On 11/28/2012 06:56 PM, Rob Bradford wrote: Hi Ander, good catch.. On 28 November 2012 15:10, Ander Conselvan de Oliveira wrote: The implementation of buffer transformation didn't handle transformed shm buffers properly. The partial texture upload was broken since the damage is in surface coor

Re: [PATCH weston] compositor: Fix rendering with shm transformed buffers

2012-11-28 Thread Rob Bradford
Hi Ander, good catch.. On 28 November 2012 15:10, Ander Conselvan de Oliveira wrote: > The implementation of buffer transformation didn't handle transformed > shm buffers properly. The partial texture upload was broken since the > damage is in surface coordinates that don't necessarily match the

[PATCH weston] compositor: Fix rendering with shm transformed buffers

2012-11-28 Thread Ander Conselvan de Oliveira
The implementation of buffer transformation didn't handle transformed shm buffers properly. The partial texture upload was broken since the damage is in surface coordinates that don't necessarily match the buffer's coordinates. It also wouldn't handle the buffer stride properly, resulting in incorr