Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-10-01 Thread Pekka Paalanen
On Fri, 22 Aug 2014 11:35:40 +0300 Pekka Paalanen wrote: > On Thu, 21 Aug 2014 09:08:56 -0700 > Jason Ekstrand wrote: > > > That applies to the whole series, BTW > > > > > > On Thu, Aug 21, 2014 at 9:03 AM, Jason Ekstrand > > wrote: > > > > > LGTM > > > Reviewed-by: Jason Ekstrand > > Tha

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-08-22 Thread Pekka Paalanen
On Thu, 21 Aug 2014 09:08:56 -0700 Jason Ekstrand wrote: > That applies to the whole series, BTW > > > On Thu, Aug 21, 2014 at 9:03 AM, Jason Ekstrand > wrote: > > > LGTM > > Reviewed-by: Jason Ekstrand Thank you, Jason. :-) Jasper already acked this in irc, but I would like to get an offi

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-08-21 Thread Jasper St. Pierre
On Thu, Aug 21, 2014 at 9:29 PM, Bill Spitzak wrote: > On 08/21/2014 04:30 PM, Jasper St. Pierre wrote: > > How do you create more than one copy of the role object in the first >> place? >> > > I thought you could create any number of wl_shell_surface objects for the > same wl_surface. > No, yo

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-08-21 Thread Bill Spitzak
On 08/21/2014 04:30 PM, Jasper St. Pierre wrote: How do you create more than one copy of the role object in the first place? I thought you could create any number of wl_shell_surface objects for the same wl_surface. May also be really nasty if a former object-less role is updated w

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-08-21 Thread Jasper St. Pierre
On Thu, Aug 21, 2014 at 7:18 PM, Bill Spitzak wrote: > > > On 08/21/2014 02:52 AM, Pekka Paalanen wrote: > > + Destroying the role object does not remove the role from the >> + wl_surface, but it may stop the wl_surface from "playing the role". >> + For instance, if a wl_subsurfac

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-08-21 Thread Bill Spitzak
On 08/21/2014 02:52 AM, Pekka Paalanen wrote: + Destroying the role object does not remove the role from the + wl_surface, but it may stop the wl_surface from "playing the role". + For instance, if a wl_subsurface object is destroyed, the wl_surface + it was created for wil

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-08-21 Thread Jason Ekstrand
That applies to the whole series, BTW On Thu, Aug 21, 2014 at 9:03 AM, Jason Ekstrand wrote: > LGTM > Reviewed-by: Jason Ekstrand > > > On Thu, Aug 21, 2014 at 2:52 AM, Pekka Paalanen > wrote: > >> From: Pekka Paalanen >> >> Define what a role is, and what restrictions there are. >> >> A cha

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-08-21 Thread Jason Ekstrand
LGTM Reviewed-by: Jason Ekstrand On Thu, Aug 21, 2014 at 2:52 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Define what a role is, and what restrictions there are. > > A change to existing behaviour is that a role cannot be changed at all > once set. However, this is unlikely to cause

[PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

2014-08-21 Thread Pekka Paalanen
From: Pekka Paalanen Define what a role is, and what restrictions there are. A change to existing behaviour is that a role cannot be changed at all once set. However, this is unlikely to cause problems, as there is no reason to re-use wl_surfaces in clients. v2: give more concrete examples of r