Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-16 Thread Bill Spitzak
I wish to formally state that I very seriously believe this proposal is wrong. The action must be decided by the destination client, not the way this is trying to do it. On Fri, Oct 16, 2015 at 8:59 AM, Mike Blumenkrantz wrote: > On Fri, 16 Oct 2015 16:52:44 +0100 > Daniel Stone wrote: > > > Hi

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-16 Thread Mike Blumenkrantz
On Fri, 16 Oct 2015 16:52:44 +0100 Daniel Stone wrote: > Hi, > > On Wednesday, 30 September 2015, Carlos Garnacho > wrote: > > > These 2 requests have been added: > > > > - wl_data_source.set_actions: Notifies the compositor of the > > available actions on the data source. > > - wl_data_offer.

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-16 Thread Daniel Stone
Hi, On Wednesday, 30 September 2015, Carlos Garnacho wrote: > These 2 requests have been added: > > - wl_data_source.set_actions: Notifies the compositor of the available > actions on the data source. > - wl_data_offer.set_actions: Notifies the compositor of the available > actions on the de

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-02 Thread Bill Spitzak
On Thu, Oct 1, 2015 at 1:59 PM, Carlos Garnacho wrote: > On Thu, Oct 1, 2015 at 9:47 PM, Bill Spitzak wrote: > > I really do not like the idea that the compositor is responsible for > > matching up modifiers with actions. > > > > Still trying to figure out why the destination cannot pick one of

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-01 Thread Carlos Garnacho
On Thu, Oct 1, 2015 at 9:47 PM, Bill Spitzak wrote: > I really do not like the idea that the compositor is responsible for > matching up modifiers with actions. > > Still trying to figure out why the destination cannot pick one of the > actions, rather than the compositor doing this. If the modifi

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-01 Thread Bill Spitzak
I really do not like the idea that the compositor is responsible for matching up modifiers with actions. Still trying to figure out why the destination cannot pick one of the actions, rather than the compositor doing this. If the modifiers are needed then either the destination gets the modifiers,

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-09-30 Thread Michael Catanzaro
Reviewed-by: Michael Catanzaro Nit regarding data_offer.action and data_source.action: "This event can be emitted multiple times during the drag-and-drop operation, mainly in response to source side changes (through data_source.set_actions), destination side changes (through data_offer.set_action

[PATCH wayland v4] protocol: Add DnD actions

2015-09-30 Thread Carlos Garnacho
These 2 requests have been added: - wl_data_source.set_actions: Notifies the compositor of the available actions on the data source. - wl_data_offer.set_actions: Notifies the compositor of the available actions on the destination side, plus the preferred action. Out of the data from these req