Re: [PATCH wayland v3 2/2] client: update documentation about threading

2014-12-09 Thread Pekka Paalanen
On Fri, 5 Dec 2014 14:03:28 +0100 Marek Chalupa wrote: > On 3 December 2014 at 17:04, Daniel Stone wrote: > > > Hi, > > > > On 3 December 2014 at 14:53, Marek Chalupa wrote: > > > >> + * fds[0].fd = wl_display_get_fd(display); > >> + * fds[0].event = POLLIN | POLLHUP | POLLERR; > >> > > >

Re: [PATCH wayland v3 2/2] client: update documentation about threading

2014-12-05 Thread Marek Chalupa
On 3 December 2014 at 17:04, Daniel Stone wrote: > Hi, > > On 3 December 2014 at 14:53, Marek Chalupa wrote: > >> + * fds[0].fd = wl_display_get_fd(display); >> + * fds[0].event = POLLIN | POLLHUP | POLLERR; >> > > POLLHUP and POLLERR are not valid for fds[0].events (note spelling); they > c

Re: [PATCH wayland v3 2/2] client: update documentation about threading

2014-12-03 Thread Daniel Stone
Hi, On 3 December 2014 at 14:53, Marek Chalupa wrote: > + * fds[0].fd = wl_display_get_fd(display); > + * fds[0].event = POLLIN | POLLHUP | POLLERR; > POLLHUP and POLLERR are not valid for fds[0].events (note spelling); they can be returned in revents if these events happened, but you don't

[PATCH wayland v3 2/2] client: update documentation about threading

2014-12-03 Thread Marek Chalupa
Remove out-dated documentation and add few more words about this topic. v2. replace a paragraph by better explanation from Pekka Paalanen fix other notes from reviewing v3. fix typo Signed-off-by: Marek Chalupa --- src/wayland-client.c | 104