Re: [PATCH wayland v3 1/3] scanner: refactor creating objects

2015-07-30 Thread Bryce Harrington
On Thu, Jul 30, 2015 at 05:58:05PM -0700, Bryce Harrington wrote: > On Thu, Jul 30, 2015 at 03:07:20PM +0200, Marek Chalupa wrote: > > wrap creating and initializing objects (structures) > > into functions and use them in the code. > > > > v2. make create_.* functions consistent > > (no func w

Re: [PATCH wayland v3 1/3] scanner: refactor creating objects

2015-07-30 Thread Bryce Harrington
On Thu, Jul 30, 2015 at 03:07:20PM +0200, Marek Chalupa wrote: > wrap creating and initializing objects (structures) > into functions and use them in the code. > > v2. make create_.* functions consistent > (no func will return NULL) > > Signed-off-by: Marek Chalupa Looks good Reviewed-by: B

[PATCH wayland v3 1/3] scanner: refactor creating objects

2015-07-30 Thread Marek Chalupa
wrap creating and initializing objects (structures) into functions and use them in the code. v2. make create_.* functions consistent (no func will return NULL) Signed-off-by: Marek Chalupa --- src/scanner.c | 164 +++--- 1 file changed, 11