Re: [PATCH wayland v3] protocol: add support for cross-interface enum attributes

2016-05-03 Thread Nils Chr. Brause
Very nice to see that finally landing! :) Since this patch has been created by Auke Booij back in 2015 (thank you very much!), there have been some protocol additions in the DnD area, which also need proper enum attributes. From the wayland.xml of the C++ Bindings[1]: wayland.xml:543: waylan

Re: [PATCH wayland v3] protocol: add support for cross-interface enum attributes

2016-05-03 Thread Auke Booij
On 3 May 2016 at 13:04, Pekka Paalanen wrote: > On Sat, 5 Dec 2015 12:39:12 + > Auke Booij wrote: > >> The enum attribute, for which scanner support was introduced in >> 1771299, can be used to link message arguments to s. However, >> some arguments refer to s in a different . >> >> This add

Re: [PATCH wayland v3] protocol: add support for cross-interface enum attributes

2016-05-03 Thread Pekka Paalanen
On Sat, 5 Dec 2015 12:39:12 + Auke Booij wrote: > The enum attribute, for which scanner support was introduced in > 1771299, can be used to link message arguments to s. However, > some arguments refer to s in a different . > > This adds scanner support for referring to an in a different >

Re: [PATCH wayland v3] protocol: add support for cross-interface enum attributes

2015-12-15 Thread Bill Spitzak
I believe this is correct and worth using. The only difference with mine is that the protocol-to-docbook.xsl puts the enum arg handling into it's own top-level clause, rather than as an if statement. This I think makes it more consistent with the other argument special-cases (one for object ids, a

Re: [PATCH wayland v3] protocol: add support for cross-interface enum attributes

2015-12-14 Thread Auke Booij
Bill, any chance you could review this? Or would you prefer it if this were based on your patch (which I do still support)? On 5 December 2015 at 13:39, Auke Booij wrote: > The enum attribute, for which scanner support was introduced in > 1771299, can be used to link message arguments to s. Howev

Re: [PATCH wayland v3] protocol: add support for cross-interface enum attributes

2015-12-05 Thread Nils Chr. Brause
Awesome! I hope that gets pushed soon. :) Reviewed-by: Nils Christopher Brause On Sat, Dec 5, 2015 at 1:39 PM, Auke Booij wrote: > The enum attribute, for which scanner support was introduced in > 1771299, can be used to link message arguments to s. However, > some arguments refer to s in a di

[PATCH wayland v3] protocol: add support for cross-interface enum attributes

2015-12-05 Thread Auke Booij
The enum attribute, for which scanner support was introduced in 1771299, can be used to link message arguments to s. However, some arguments refer to s in a different . This adds scanner support for referring to an in a different using dot notation. It also sets the attributes in this style in t