Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-27 Thread Bill Spitzak
I do not think there are any problems with this patch, as it is compatible with any of the proposed future enhancements (ie they will still parse all the command lines that this one accepts). On 03/27/2015 06:04 AM, Pekka Paalanen wrote: On Tue, 03 Mar 2015 09:38:22 +0100 Hardening wrote: L

Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-27 Thread Pekka Paalanen
On Tue, 03 Mar 2015 09:38:22 +0100 Hardening wrote: > Le 03/03/2015 09:11, Pekka Paalanen a écrit : > > On Mon, 2 Mar 2015 16:08:00 +0200 > > Jussi Pakkanen wrote: > > > >> Add support for direct file reading and writing in wayland-scanner. > >> > >> Signed-off-by: Jussi Pakkanen > >> > >> --

Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-03 Thread Bill Spitzak
This is my suggested alteration of the patch to allow 3 arguments, there is a * in front of my changed or added lines: - if (argc != 2) * +if (argc < 2 || argc > 4) usage(EXIT_FAILURE); else if (strcmp(argv[1], "help") == 0 || strcmp(argv[1], "--help") == 0)

Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-03 Thread Hardening
Le 03/03/2015 09:11, Pekka Paalanen a écrit : > On Mon, 2 Mar 2015 16:08:00 +0200 > Jussi Pakkanen wrote: > >> Add support for direct file reading and writing in wayland-scanner. >> >> Signed-off-by: Jussi Pakkanen >> >> --- >> src/scanner.c | 26 +- >> 1 file changed,

Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-03 Thread Pekka Paalanen
On Mon, 2 Mar 2015 16:08:00 +0200 Jussi Pakkanen wrote: > Add support for direct file reading and writing in wayland-scanner. > > Signed-off-by: Jussi Pakkanen > > --- > src/scanner.c | 26 +- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/src/sc

[PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-02 Thread Jussi Pakkanen
Add support for direct file reading and writing in wayland-scanner. Signed-off-by: Jussi Pakkanen --- src/scanner.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 1f1e59a..efdc69c 100644 --- a/src/scanner.c +++