Re: [PATCH wayland v2 1/2] scanner: refactor creating objects

2015-07-29 Thread Bryce Harrington
On Mon, Jul 27, 2015 at 09:17:15AM +0200, Marek Chalupa wrote: > Hi, > thanks for review. > > On 07/23/2015 08:41 PM, Bryce Harrington wrote: > >On Thu, Jul 23, 2015 at 07:39:30AM +0200, Marek Chalupa wrote: > >>wrap creating and initializing objects (structures) > >>into functions and use them in

Re: [PATCH wayland v2 1/2] scanner: refactor creating objects

2015-07-27 Thread Marek Chalupa
Hi, thanks for review. On 07/23/2015 08:41 PM, Bryce Harrington wrote: On Thu, Jul 23, 2015 at 07:39:30AM +0200, Marek Chalupa wrote: wrap creating and initializing objects (structures) into functions and use them in the code. Signed-off-by: Marek Chalupa --- src/scanner.c | 158 +++

Re: [PATCH wayland v2 1/2] scanner: refactor creating objects

2015-07-23 Thread Bryce Harrington
On Thu, Jul 23, 2015 at 07:39:30AM +0200, Marek Chalupa wrote: > wrap creating and initializing objects (structures) > into functions and use them in the code. > > Signed-off-by: Marek Chalupa > --- > src/scanner.c | 158 > ++ > 1 file cha

Re: [PATCH wayland v2 1/2] scanner: refactor creating objects

2015-07-23 Thread Derek Foreman
These both look OK to me now... Reviewed-By: Derek Foreman On 23/07/15 12:39 AM, Marek Chalupa wrote: > wrap creating and initializing objects (structures) > into functions and use them in the code. > > Signed-off-by: Marek Chalupa > --- > src/scanner.c | 158 > ++

[PATCH wayland v2 1/2] scanner: refactor creating objects

2015-07-22 Thread Marek Chalupa
wrap creating and initializing objects (structures) into functions and use them in the code. Signed-off-by: Marek Chalupa --- src/scanner.c | 158 ++ 1 file changed, 105 insertions(+), 53 deletions(-) diff --git a/src/scanner.c b/src/scann