Re: [PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

2016-11-21 Thread Daniel Stone
Hi, On 21 November 2016 at 20:59, Yong Bakos wrote: > On Nov 21, 2016, at 9:14 AM, Daniel Stone wrote: >> I think removing the final word 'the dispatcher-specific >> implementation data' is a loss of precision/accuracy. If you don't >> mind reinstating that final word, I'll merge with my R-b. >

Re: [PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

2016-11-21 Thread Yong Bakos
Hi Daniel, > On Nov 21, 2016, at 9:14 AM, Daniel Stone wrote: > > Hi Yong, > > On 21 November 2016 at 13:44, Yong Bakos wrote: >> - * A dispatcher takes five arguments: The first is the dispatcher-specific >> - * implementation data associated with the target object. The second is the >> - *

Re: [PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

2016-11-21 Thread Daniel Stone
Hi Yong, On 21 November 2016 at 13:44, Yong Bakos wrote: > - * A dispatcher takes five arguments: The first is the dispatcher-specific > - * implementation data associated with the target object. The second is the > - * object on which the callback is being invoked (either wl_proxy or > - * wl_

[PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

2016-11-21 Thread Yong Bakos
From: Yong Bakos Adjust the brief, clarify the behavior and arguments, correct a grammar error, document the parameters, and document the return type. Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington --- v2: Document intent of return type. src/wayland-util.h | 27 +