Re: [PATCH wayland v2] server: don't send an error to NULL display_resource

2016-01-13 Thread Bryce Harrington
On Mon, Jan 11, 2016 at 11:33:32AM -0600, Derek Foreman wrote: > On 11/01/16 04:45 AM, Marek Chalupa wrote: > > if display_resource = wl_resource_create() fails in bind_display(), > > we call wl_client_post_no_memory() which is wrong, since this function > > uses display_resource (which is NULL at

Re: [PATCH wayland v2] server: don't send an error to NULL display_resource

2016-01-11 Thread Bill Spitzak
I like this minimal fix better than the previous one that fixed the bug twice. I think it would be clearer to just state that "wl_resource_post_error will crash if display_resource is null". On Mon, Jan 11, 2016 at 9:33 AM, Derek Foreman wrote: > On 11/01/16 04:45 AM, Marek Chalupa wrote: > >

Re: [PATCH wayland v2] server: don't send an error to NULL display_resource

2016-01-11 Thread Derek Foreman
On 11/01/16 04:45 AM, Marek Chalupa wrote: > if display_resource = wl_resource_create() fails in bind_display(), > we call wl_client_post_no_memory() which is wrong, since this function > uses display_resource (which is NULL at this point). > said simply: don't send an error to resource that you've

[PATCH wayland v2] server: don't send an error to NULL display_resource

2016-01-11 Thread Marek Chalupa
if display_resource = wl_resource_create() fails in bind_display(), we call wl_client_post_no_memory() which is wrong, since this function uses display_resource (which is NULL at this point). said simply: don't send an error to resource that you've just failed to create) https://bugs.freedesktop.o