Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Jason Ekstrand
On Wed, Aug 20, 2014 at 12:52 PM, Bill Spitzak wrote: > > > On 08/20/2014 03:06 AM, Pekka Paalanen wrote: > >> On Tue, 19 Aug 2014 13:04:54 -0700 >> Bill Spitzak wrote: >> > > Destroying the last protocol object for the role does not remove the >>> role, correct? The client can recreate a new p

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Bill Spitzak
On 08/20/2014 03:06 AM, Pekka Paalanen wrote: On Tue, 19 Aug 2014 13:04:54 -0700 Bill Spitzak wrote: Destroying the last protocol object for the role does not remove the role, correct? The client can recreate a new protocol object for that role and it still works? Recreating the same role

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Pekka Paalanen
On Wed, 20 Aug 2014 13:26:44 +0300 Pekka Paalanen wrote: > On Tue, 19 Aug 2014 10:16:34 -0700 > Jason Ekstrand wrote: > > > Pekka, > > I have one nitpick below. However, if we can't find a good solution, I'm > > ok with pushing as-is. > > > > Reviewed-by: Jason Ekstrand > > > > > > On Tue,

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 10:16:34 -0700 Jason Ekstrand wrote: > Pekka, > I have one nitpick below. However, if we can't find a good solution, I'm > ok with pushing as-is. > > Reviewed-by: Jason Ekstrand > > > On Tue, Aug 19, 2014 at 1:41 AM, Pekka Paalanen wrote: > > > On Tue, 19 Aug 2014 10:29

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 13:04:54 -0700 Bill Spitzak wrote: > On 08/19/2014 12:29 AM, Pekka Paalanen wrote: > > > + Often, this > > + request also creates a new protocol object that represents the > > + role and adds additional functionality to wl_surface. When a > > + client want

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-19 Thread Bill Spitzak
On 08/19/2014 12:29 AM, Pekka Paalanen wrote: + Often, this + request also creates a new protocol object that represents the + role and adds additional functionality to wl_surface. When a + client wants to destroy a wl_surface, they must destroy this 'role + object' befo

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-19 Thread Jason Ekstrand
Pekka, I have one nitpick below. However, if we can't find a good solution, I'm ok with pushing as-is. Reviewed-by: Jason Ekstrand On Tue, Aug 19, 2014 at 1:41 AM, Pekka Paalanen wrote: > On Tue, 19 Aug 2014 10:29:21 +0300 > Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > Define w

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-19 Thread Pekka Paalanen
On Tue, 19 Aug 2014 10:29:21 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Define what a role is, and what restrictions there are. > > A change to existing behaviour is that a role cannot be changed at all > once set. However, this is unlikely to cause problems, as there is no > reaso

[PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-19 Thread Pekka Paalanen
From: Pekka Paalanen Define what a role is, and what restrictions there are. A change to existing behaviour is that a role cannot be changed at all once set. However, this is unlikely to cause problems, as there is no reason to re-use wl_surfaces in clients. v2: give more concrete examples of r