Re: EXT: Re: [PATCH wayland v2] contributing: use Gitlab merge request workflow

2019-03-07 Thread Pekka Paalanen
On Wed, 6 Mar 2019 07:33:01 -0600 Derek Foreman wrote: > On Wed, 6 Mar 2019 at 04:49, Ray, Ian (GE Healthcare) wrote: > > > > > > > > > On 6 Mar 2019, at 11.28, Pekka Paalanen wrote: > > > > > > Going once, going twice... > > > > > > Any objections? More acks? > > Acked-by: Derek Foreman

Re: EXT: Re: [PATCH wayland v2] contributing: use Gitlab merge request workflow

2019-03-06 Thread Derek Foreman
On Wed, 6 Mar 2019 at 04:49, Ray, Ian (GE Healthcare) wrote: > > > > > On 6 Mar 2019, at 11.28, Pekka Paalanen wrote: > > > > Going once, going twice... > > > > Any objections? More acks? Acked-by: Derek Foreman Personally, I really see no harm in pushing this during code freeze, since it's no

Re: EXT: Re: [PATCH wayland v2] contributing: use Gitlab merge request workflow

2019-03-06 Thread Ray, Ian (GE Healthcare)
> On 6 Mar 2019, at 11.28, Pekka Paalanen wrote: > > Going once, going twice... > > Any objections? More acks? > > Let's say I'll push this and enable MRs on Friday if there are no > further comments. More acks and I might do it sooner. :-) > > LGTM Acked-by: Ian Ray > Thanks, > pq >

Re: [PATCH wayland v2] contributing: use Gitlab merge request workflow

2019-03-06 Thread Scott Anderson
On 27/02/19 11:35 pm, Pekka Paalanen wrote: From: Pekka Paalanen The experience from Weston shows that the Gitlab merge request based workflow works really well. Recently there have also been issues with the mailing list that have made the email based workflow more painful than it used to be. T

Re: [PATCH wayland v2] contributing: use Gitlab merge request workflow

2019-03-06 Thread Pekka Paalanen
Going once, going twice... Any objections? More acks? Let's say I'll push this and enable MRs on Friday if there are no further comments. More acks and I might do it sooner. :-) Thanks, pq On Wed, 27 Feb 2019 12:35:09 +0200 Pekka Paalanen wrote: > From: Pekka Paalanen > > The experience f

[PATCH wayland v2] contributing: use Gitlab merge request workflow

2019-02-27 Thread Pekka Paalanen
From: Pekka Paalanen The experience from Weston shows that the Gitlab merge request based workflow works really well. Recently there have also been issues with the mailing list that have made the email based workflow more painful than it used to be. Those issues might have been temporary or occas