Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-16 Thread Jonas Ådahl
On Tue, Jan 12, 2016 at 10:01:17AM +, Daniel Stone wrote: > On 12 January 2016 at 04:31, Jonas Ådahl wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until there > > data to read, which could mean that w

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-15 Thread Jonas Ådahl
On Fri, Jan 15, 2016 at 11:43:33AM -0800, Bill Spitzak wrote: > Would it make sense for wl_display_flush() to do this always? Ie it will > never return EAGAIN. Then if needed make the non-blocking version be a new > call. No, we can't change the semantics of wl_display_flush() to be blocking, as i

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-15 Thread Bill Spitzak
Would it make sense for wl_display_flush() to do this always? Ie it will never return EAGAIN. Then if needed make the non-blocking version be a new call. On Thu, Jan 14, 2016 at 6:40 PM, Jonas Ådahl wrote: > On Fri, Jan 15, 2016 at 12:12:09AM +, Auke Booij wrote: > > On 12 January 2016 at

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-14 Thread Jonas Ådahl
On Fri, Jan 15, 2016 at 12:12:09AM +, Auke Booij wrote: > On 12 January 2016 at 04:31, Jonas Ådahl wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until there > > + is Fixed locally. > > > data to r

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-14 Thread Jonas Ådahl
On Thu, Jan 14, 2016 at 04:59:48PM -0600, Derek Foreman wrote: > On 11/01/16 10:31 PM, Jonas Ådahl wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until there > > data to read, which could mean that we block

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-14 Thread Auke Booij
On 12 January 2016 at 04:31, Jonas Ådahl wrote: > wl_display_flush() may fail with EAGAIN which means that not all data > waiting in the buffer has been flushed. We later block until there + is > data to read, which could mean that we block on input from the > compositor without having sent out

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-14 Thread Derek Foreman
On 11/01/16 10:31 PM, Jonas Ådahl wrote: > wl_display_flush() may fail with EAGAIN which means that not all data > waiting in the buffer has been flushed. We later block until there > data to read, which could mean that we block on input from the > compositor without having sent out all data from t

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-12 Thread Daniel Stone
On 12 January 2016 at 04:31, Jonas Ådahl wrote: > wl_display_flush() may fail with EAGAIN which means that not all data > waiting in the buffer has been flushed. We later block until there > data to read, which could mean that we block on input from the > compositor without having sent out all dat

[PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-11 Thread Jonas Ådahl
wl_display_flush() may fail with EAGAIN which means that not all data waiting in the buffer has been flushed. We later block until there data to read, which could mean that we block on input from the compositor without having sent out all data from the client. Avoid this by fully flushing the socke