Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-15 Thread Emilio Pozuelo Monfort
On 11/11/16 15:56, Pekka Paalanen wrote: > On Thu, 10 Nov 2016 12:18:55 +0200 > Pekka Paalanen wrote: > >> On Thu, 10 Nov 2016 11:11:51 +0100 >> Emilio Pozuelo Monfort wrote: >> >>> On 10/11/16 10:57, Pekka Paalanen wrote: From: Pekka Paalanen Add tests that ensure that wayland

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-14 Thread Emil Velikov
On 14 November 2016 at 09:28, Pekka Paalanen wrote: > On Fri, 11 Nov 2016 20:31:54 + > Emil Velikov wrote: > >> Hi Pekka, >> >> It's great to see some tests for the scanner. There's a few thoughts I >> may have mentioned before - please don't read too much into them. >> >> On 10 November 2016

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-14 Thread Pekka Paalanen
On Fri, 11 Nov 2016 20:31:54 + Emil Velikov wrote: > Hi Pekka, > > It's great to see some tests for the scanner. There's a few thoughts I > may have mentioned before - please don't read too much into them. > > On 10 November 2016 at 09:57, Pekka Paalanen wrote: > > From: Pekka Paalanen >

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-11 Thread Emil Velikov
Hi Pekka, It's great to see some tests for the scanner. There's a few thoughts I may have mentioned before - please don't read too much into them. On 10 November 2016 at 09:57, Pekka Paalanen wrote: > From: Pekka Paalanen > > Add tests that ensure that wayland-scanner output for a given input d

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-11 Thread Pekka Paalanen
On Thu, 10 Nov 2016 12:18:55 +0200 Pekka Paalanen wrote: > On Thu, 10 Nov 2016 11:11:51 +0100 > Emilio Pozuelo Monfort wrote: > > > On 10/11/16 10:57, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > Add tests that ensure that wayland-scanner output for a given input does > > >

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-10 Thread Pekka Paalanen
On Thu, 10 Nov 2016 11:11:51 +0100 Emilio Pozuelo Monfort wrote: > On 10/11/16 10:57, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Add tests that ensure that wayland-scanner output for a given input does > > not change unexpectedly. This makes it very easy to review > > wayland-scanne

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-10 Thread Emilio Pozuelo Monfort
On 10/11/16 10:57, Pekka Paalanen wrote: > From: Pekka Paalanen > > Add tests that ensure that wayland-scanner output for a given input does > not change unexpectedly. This makes it very easy to review > wayland-scanner patches. > > Before, when patches were proposed for wayland-scanner, I had t

[PATCH wayland 3/3] tests: add scanner tests

2016-11-10 Thread Pekka Paalanen
From: Pekka Paalanen Add tests that ensure that wayland-scanner output for a given input does not change unexpectedly. This makes it very easy to review wayland-scanner patches. Before, when patches were proposed for wayland-scanner, I had to build wayland without the patches, save the generated