Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

2015-07-16 21:57 GMT+03:00 Derek Foreman : > > I'm wondering if buffer->pool can ever actually be NULL anyway... I > have a suspicion that it can't, making the assert and the test a little > silly. It seems to me it can only be NULL if the buffer is created with wl_shm_buffer_create() which is b

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

On 16/07/15 03:02 AM, Hardening wrote: > Le 01/07/2015 12:52, Marek Chalupa a écrit : >> >> >> On Wed, Jul 1, 2015 at 11:25 AM, Marek Chalupa > > wrote: >> >> >> >> On Fri, Jun 26, 2015 at 6:35 PM, Derek Foreman >> mailto:der...@osg.samsung.com>> wrote: >> >>

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

Le 01/07/2015 12:52, Marek Chalupa a écrit : > > > On Wed, Jul 1, 2015 at 11:25 AM, Marek Chalupa > wrote: > > > > On Fri, Jun 26, 2015 at 6:35 PM, Derek Foreman > mailto:der...@osg.samsung.com>> wrote: > > There's no situation where a shm buffer w

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

On Wed, Jul 1, 2015 at 11:25 AM, Marek Chalupa wrote: > > > On Fri, Jun 26, 2015 at 6:35 PM, Derek Foreman > wrote: > >> There's no situation where a shm buffer without a pool makes sense, >> so we enforce the pool's existence a little more rigidly. >> >> Signed-off-by: Derek Foreman >> --- >>

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

On Fri, Jun 26, 2015 at 6:35 PM, Derek Foreman wrote: > There's no situation where a shm buffer without a pool makes sense, > so we enforce the pool's existence a little more rigidly. > > Signed-off-by: Derek Foreman > --- > src/wayland-shm.c | 10 ++ > 1 file changed, 6 insertions(+),

[PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

There's no situation where a shm buffer without a pool makes sense, so we enforce the pool's existence a little more rigidly. Signed-off-by: Derek Foreman --- src/wayland-shm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c in