Re: [PATCH wayland 3/3] scanner: check for wayland-scanner.pc before using variables

2013-08-08 Thread Kristian Høgsberg
On Wed, Aug 07, 2013 at 04:33:20PM +1000, Peter Hutterer wrote: > On Wed, Aug 07, 2013 at 07:46:43AM +0200, Daiki Ueno wrote: > > Hi, > > > > Peter Hutterer writes: > > > > > AC_DEFUN([WAYLAND_SCANNER_RULES], [ > > > PKG_PROG_PKG_CONFIG > > > > > > +PKG_CHECK_MODULES([WAYLAND_SCANNER

Re: [PATCH wayland 3/3] scanner: check for wayland-scanner.pc before using variables

2013-08-06 Thread Peter Hutterer
On Wed, Aug 07, 2013 at 07:46:43AM +0200, Daiki Ueno wrote: > Hi, > > Peter Hutterer writes: > > > AC_DEFUN([WAYLAND_SCANNER_RULES], [ > > PKG_PROG_PKG_CONFIG > > > > +PKG_CHECK_MODULES([WAYLAND_SCANNER], [wayland-scanner]) > > + > > With this change, configure will abort if wayland

Re: [PATCH wayland 3/3] scanner: check for wayland-scanner.pc before using variables

2013-08-06 Thread Daiki Ueno
Hi, Peter Hutterer writes: > AC_DEFUN([WAYLAND_SCANNER_RULES], [ > PKG_PROG_PKG_CONFIG > > +PKG_CHECK_MODULES([WAYLAND_SCANNER], [wayland-scanner]) > + With this change, configure will abort if wayland-scanner.pc is not found. However, the current WAYLAND_SCANNER_RULES cannot be in

[PATCH wayland 3/3] scanner: check for wayland-scanner.pc before using variables

2013-08-06 Thread Peter Hutterer
If wayland-scanner.pc can't be found the variables end up being set irrespectively, leaving the user with odd compiler errors about missing headers, etc. --- wayland-scanner.m4 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/wayland-scanner.m4 b/wayland-scanner.m4 index 2b87c5f..4e4222a 1006