Re: [PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-28 Thread Bill Spitzak
Jason Ekstrand wrote: while a more modern compositor implementation would look like this: wl_foo_interface foo_implementation = { set_bar, set_twiddle }; As it stands, libwayland does not checking of requests beyond a simple check to see request n is devined in the wl_interface object

Re: [PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-28 Thread Jason Ekstrand
On Thu, Jun 27, 2013 at 8:31 PM, Bill Spitzak wrote: > Jason Ekstrand wrote: > > That is exactly what this patch allows you to do. More particularly, >> this patch protects the compositor from bad clients that attempt to use >> requests that are not supported by the compositor. In the current

Re: [PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-27 Thread Bill Spitzak
Jason Ekstrand wrote: That is exactly what this patch allows you to do. More particularly, this patch protects the compositor from bad clients that attempt to use requests that are not supported by the compositor. In the current implementation, the compositor simply crashes. I'm confused a

Re: [PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-27 Thread Jason Ekstrand
On Thu, Jun 27, 2013 at 1:19 PM, Bill Spitzak wrote: > > > Jason Ekstrand wrote: > >> This commit adds version information to wl_message signatures and a >> wl_message_get_since function to retrieve. The since version comes in the >> form of a (possible) integer at the begining of the message.

Re: [PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-27 Thread Bill Spitzak
Jason Ekstrand wrote: This commit adds version information to wl_message signatures and a wl_message_get_since function to retrieve. The since version comes in the form of a (possible) integer at the begining of the message. If the message starts with an integer, then it specifies the "since"

[PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-26 Thread Jason Ekstrand
This commit adds version information to wl_message signatures and a wl_message_get_since function to retrieve. The since version comes in the form of a (possible) integer at the begining of the message. If the message starts with an integer, then it specifies the "since" version of that message.