Re: [PATCH wayland 2/2] scanner: Make emit_structs more explicit

2014-08-18 Thread Pekka Paalanen
On Mon, 11 Aug 2014 10:04:01 +0200 Marek Chalupa wrote: > The code looks clearer, seems working and I haven't found any issue in the > code, therefore: > > Reviewed-by: Marek Chalupa > > For both patches I checked that the scanner output in both Wayland and Weston stays identical. Both patche

Re: [PATCH wayland 2/2] scanner: Make emit_structs more explicit

2014-08-11 Thread Marek Chalupa
The code looks clearer, seems working and I haven't found any issue in the code, therefore: Reviewed-by: Marek Chalupa For both patches On 9 August 2014 00:22, Jasper St. Pierre wrote: > "is_interface" is a really terrible name for the client or server > variants, and instead of checking whe

[PATCH wayland 2/2] scanner: Make emit_structs more explicit

2014-08-08 Thread Jasper St. Pierre
"is_interface" is a really terrible name for the client or server variants, and instead of checking whether we were passed the requests or the events, just pass an argument through. --- src/scanner.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/sr