Re: [PATCH wayland 2/2] protocol: Clarify semantics of wl_subsurface.set_position

2014-01-20 Thread Bill Spitzak
Rather than say "schedule the coordinate change" I think it would be clearer to say something like this: "This changes the scheduled coordinates of the sub-surface." "The next wl_surface.commit on the parent surface will reset the sub-surface's position to the scheduled coordinates." "The in

Re: [PATCH wayland 2/2] protocol: Clarify semantics of wl_subsurface.set_position

2014-01-19 Thread Pekka Paalanen
On Sun, 19 Jan 2014 10:32:11 +0100 Jonas Ådahl wrote: > Make it clear that multiple requests before commit are allowed and how it > is handled. > > Signed-off-by: Jonas Ådahl > --- > protocol/wayland.xml | 4 > 1 file changed, 4 insertions(+) > > diff --git a/protocol/wayland.xml b/proto

Re: [PATCH wayland 2/2] protocol: Clarify semantics of wl_subsurface.set_position

2014-01-19 Thread Jasper St. Pierre
Reviewed-by: Jasper St. Pierre On Sun, Jan 19, 2014 at 4:32 AM, Jonas Ådahl wrote: > Make it clear that multiple requests before commit are allowed and how it > is handled. > > Signed-off-by: Jonas Ådahl > --- > protocol/wayland.xml | 4 > 1 file changed, 4 insertions(+) > > diff --git

[PATCH wayland 2/2] protocol: Clarify semantics of wl_subsurface.set_position

2014-01-19 Thread Jonas Ådahl
Make it clear that multiple requests before commit are allowed and how it is handled. Signed-off-by: Jonas Ådahl --- protocol/wayland.xml | 4 1 file changed, 4 insertions(+) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index b986c86..d47ee62 100644 --- a/protocol/wayland.xml +