Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-31 Thread Bill Spitzak
On Fri, Mar 25, 2016 at 12:16 AM, Daiki Ueno wrote: > > > + > > + Allows to atomically send state updates from client. > > + > > + This request should follow after a batch of state updating requests > > + like set_surrounding_text, set_content_type, set_cursor_rectangle > and >

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-29 Thread Daiki Ueno
Bill Spitzak writes: > On Fri, Mar 25, 2016 at 12:16 AM, Daiki Ueno wrote: > > > > + > > + Allows to atomically send state updates from client. > > + > > + This request should follow after a batch of state updating requests > > + like set_surrounding_text, set_content_type, set_cursor_rect

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-26 Thread Jan Arne Petersen
On Fri, Mar 25, 2016 at 8:16 AM Daiki Ueno wrote: > Hello, > > Jan Arne Petersen writes: > > > There is a reference implementation of this version of the protocol in > QtWayland > > https://codereview.qt-project.org/#/c/153711/ where the text-input > protocol is used to proxy the > > Qt input me

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-26 Thread Jan Arne Petersen
Hi, Thanks for the feedback. On Thu, Mar 24, 2016, 00:55 Weng Xuetian wrote: > This look much more promising from input method point of view comparing > with > previous version. I tried to implement inputmethod protocol v1 for wayland > in > fcitx quite some time ago, but I never put it in rea

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-25 Thread Daiki Ueno
Hello, Jan Arne Petersen writes: > There is a reference implementation of this version of the protocol in > QtWayland > https://codereview.qt-project.org/#/c/153711/ where the text-input protocol > is used to proxy the > Qt input method of Qt Wayland clients to the Qt input method on composito

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-23 Thread Weng Xuetian
This look much more promising from input method point of view comparing with previous version. I tried to implement inputmethod protocol v1 for wayland in fcitx quite some time ago, but I never put it in real use because.. it's not really practical comparing with what we have in customized im mo

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-23 Thread Jan Arne Petersen
There is a reference implementation of this version of the protocol in QtWayland https://codereview.qt-project.org/#/c/153711/ where the text-input protocol is used to proxy the Qt input method of Qt Wayland clients to the Qt input method on compositor side. One can then use for example the qtvirt

[PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-14 Thread Jan Arne Petersen
There were some shortcomings in the first version of the protocol which makes it not really useful in real world applications. It is not really possible to fix them in a compatible way so introduce a new v2 of the protocol. Fixes some shortcomings of the first version: * Use only one wp_text_inpu