Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-22 Thread Jonas Ådahl
On Thu, Jun 22, 2017 at 06:38:00PM +0100, David Edmundson wrote: > > > > For flipping, it's a bit more non straight forward, as > > flipping and the offset are not very useful in combination, > > > > Yes, I think it's only when flipped where we need some additional > clarification. > > > > How a

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-22 Thread Jonas Ådahl
On Thu, Jun 22, 2017 at 05:30:49PM +0100, David Edmundson wrote: > > > > > > > > > > > I suggest continuing talking about "direction" here. An alternative to > > the above could be, changing the original text just a bit: > > > > The thing I struggled with when trying to first understand v6 i

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-22 Thread David Edmundson
> > For flipping, it's a bit more non straight forward, as > flipping and the offset are not very useful in combination, > Yes, I think it's only when flipped where we need some additional clarification. > How about we add the following paragraph to the flip_x/y descriptions: > > The a

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-22 Thread David Edmundson
> > > > > > I suggest continuing talking about "direction" here. An alternative to > the above could be, changing the original text just a bit: > The thing I struggled with when trying to first understand v6 is that "bottom" isn't a direction, it's a position. I've changed it in a way that s

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-20 Thread Jonas Ådahl
On Tue, Jun 20, 2017 at 06:54:34PM +0100, David Edmundson wrote: > You missed a line in "xdg-shell/positioner: Allow empty anchor_rect" > You might want to squash this with that. > From 0a21378302d63a83a10723b41adf35e605fb35f5 Mon Sep 17 00:00:00 2001 > From: David Edmundson > Date: Tue, 20 J

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-20 Thread Jonas Ådahl
On Tue, Jun 20, 2017 at 06:55:41PM +0100, David Edmundson wrote: > ​ > From 093ed1a17a483792e316f932e15a566ab2653838 Mon Sep 17 00:00:00 2001 > From: David Edmundson > Date: Tue, 20 Jun 2017 18:51:45 +0100 > Subject: [PATCH 2/2] xdg-shell/positioner: Replace edge bitfield with extended > enum >

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-20 Thread David Edmundson
​ From 093ed1a17a483792e316f932e15a566ab2653838 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Tue, 20 Jun 2017 18:51:45 +0100 Subject: [PATCH 2/2] xdg-shell/positioner: Replace edge bitfield with extended enum Bitfields allowed for impossible combinations of anchor edges, such as being on

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-20 Thread David Edmundson
You missed a line in "xdg-shell/positioner: Allow empty anchor_rect" You might want to squash this with that. From 0a21378302d63a83a10723b41adf35e605fb35f5 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Tue, 20 Jun 2017 18:29:59 +0100 Subject: [PATCH 1/2] Fix xdg-shell/positioner: Allow

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-14 Thread Jonas Ådahl
On Fri, Jun 02, 2017 at 09:54:31AM +0100, David Edmundson wrote: > I have some comments/questions on the current v6 interface which I'd like > clarifying before we make it stable. > > The Positioner anchor and gravity both takes the edge as a bitfield of > flags. > > It's then part of the protoco

RE: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-06-02 Thread David Edmundson
I have some comments/questions on the current v6 interface which I'd like clarifying before we make it stable. The Positioner anchor and gravity both takes the edge as a bitfield of flags. It's then part of the protocol to say "If two parallel anchor edges are specified (e.g. 'left' and 'right'),

Re: [PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-05-24 Thread Yong Bakos
Hi Jonas, Regarding renaming, > On May 24, 2017, at 2:35 AM, Jonas Ådahl wrote: > > Hi, > > I think it is time to take the next step regarding xdg_shell: declaring it > stable. The current unstable version (xdg_shell unstable v6) has been > implemented in multiple code bases, used by multiple d

[PATCH wayland-protocols 00/11] Declaring xdg-shell stable

2017-05-24 Thread Jonas Ådahl
Hi, I think it is time to take the next step regarding xdg_shell: declaring it stable. The current unstable version (xdg_shell unstable v6) has been implemented in multiple code bases, used by multiple desktop environments for quite some time, and I think this proves it is time to take the next st