Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-09-06 Thread Pekka Paalanen
On Thu, 05 Sep 2019 12:41:44 + "Victor Berger" wrote: > Hi, > > 30 août 2019 14:18 "Daniel Stone" a écrit: > > > Hi, > > > > On Fri, 30 Aug 2019 at 08:45, Pekka Paalanen wrote: > > > >> I don't recall hearing much from people with custom code generating > >> scanners, so until we upset

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-09-05 Thread Victor Berger
Hi, 30 août 2019 14:18 "Daniel Stone" a écrit: > Hi, > > On Fri, 30 Aug 2019 at 08:45, Pekka Paalanen wrote: > >> I don't recall hearing much from people with custom code generating >> scanners, so until we upset someone and they come to us complaining >> about regressions the first time, I am

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-30 Thread Daniel Stone
Hi, On Fri, 30 Aug 2019 at 08:45, Pekka Paalanen wrote: > On Wed, 28 Aug 2019 14:49:37 + Simon Ser wrote: > > On Tuesday, August 20, 2019 2:43 PM, Victor Berger > > wrote: > > > I can't talk for other projects, but in the case of wayland-rs this > > > kind of corrections to the protocol fi

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-30 Thread Simon Ser
On Friday, August 30, 2019 10:45 AM, Pekka Paalanen wrote: > On Wed, 28 Aug 2019 14:49:37 + > Simon Ser cont...@emersion.fr wrote: > > > On Tuesday, August 20, 2019 2:43 PM, Victor Berger victor.ber...@m4x.org > > wrote: > > > > > 20 août 2019 13:30 "Simon Ser" cont...@emersion.fr a écrit: >

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-30 Thread Pekka Paalanen
On Wed, 28 Aug 2019 14:49:37 + Simon Ser wrote: > On Tuesday, August 20, 2019 2:43 PM, Victor Berger > wrote: > > 20 août 2019 13:30 "Simon Ser" cont...@emersion.fr a écrit: > > > > > So now the question is: some scanners may have generated some code from > > > presentation-time.xml. Some

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-28 Thread Simon Ser
On Tuesday, August 20, 2019 2:43 PM, Victor Berger wrote: > 20 août 2019 13:30 "Simon Ser" cont...@emersion.fr a écrit: > > > So now the question is: some scanners may have generated some code from > > presentation-time.xml. Some scanners may generate different code for > > bitfields, maybe break

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-20 Thread Victor Berger
20 août 2019 13:30 "Simon Ser" a écrit: > So now the question is: some scanners may have generated some code from > presentation-time.xml. Some scanners may generate different code for > bitfields, maybe breaking ABI. Is it fine to add the bitfield > attribute? > > For instance, wayland-rs seems

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-20 Thread Simon Ser
On Tuesday, August 20, 2019 2:20 PM, Jonas Ådahl wrote: > On Tue, Aug 20, 2019 at 10:48:40AM +, Simon Ser wrote: > > > That's a good catch. > > However I don't know if this can be considered backwards-compatible. > > For wayland-scanner it doesn't make a difference, but what about other > > s

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-20 Thread Jonas Ådahl
On Tue, Aug 20, 2019 at 10:48:40AM +, Simon Ser wrote: > That's a good catch. > > However I don't know if this can be considered backwards-compatible. > For wayland-scanner it doesn't make a difference, but what about other > scanners? I don't think it's reasonable to avoid using any new XML

Re: [PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-20 Thread Simon Ser
That's a good catch. However I don't know if this can be considered backwards-compatible. For wayland-scanner it doesn't make a difference, but what about other scanners? The commit introducing bitfields in the DTD predates presentation-time. commit e65aed46168fc86a7e78db071472278ea533f526 Autho

[PATCH wayland-protocols] presentation-time: add missing bitfield marker

2019-08-20 Thread Ivan Molodetskikh
--- stable/presentation-time/presentation-time.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stable/presentation-time/presentation-time.xml b/stable/presentation-time/presentation-time.xml index a46994c..6063c53 100644 --- a/stable/presentation-time/presentation-time.xml