I have already taken off that patch from the patchwork list...
and pushed a simpler version...
http://lists.freedesktop.org/archives/wayland-devel/2014-November/018030.html
BR
imran
On Wed, Nov 5, 2014 at 5:08 PM, Pekka Paalanen wrote:
> On Wed, 15 Oct 2014 22:04:46 +0300
> Imran Zaman wrote:
On Wed, 15 Oct 2014 22:04:46 +0300
Imran Zaman wrote:
> The reason is that strtol is used at many places in weston/wayland..
> and its not covering all the error cases everywhere (i.e. its buggy)..
> so its better to
> encapsulate it in a function with all the input and output checks...
> it can
Here are my comments:
Giulio Camuffo: if we copy-paste the same code to weston as well,
means we have to write tests etc for two functions in weston as well;
and it will come with maintenance overhead without any benefit of
hiding the APIs in wayland (I can take the responsibility of
maintaining th
On Wed, Oct 15, 2014 at 04:18:59PM +0300, Imran Zaman wrote:
> Hi
>
> The patch is used to replace strtol and strtoul with wl_strtol and
> wl_strtoul with inputs and result checks.
>
> The utility functions are used extensively in wayland and weston so added
These utility...
> appropriate
> inp
On Wednesday 15 October 2014 16:14:17 Imran Zaman wrote:
> Hi
>
> The patch is used to replace strtol and strtoul with wl_strtol and
> wl_strtoul with inputs and result checks.
>
> The utility functions are used extensively in wayland and weston so added
> appropriate
> input and output checks; t
On Wednesday 15 October 2014 16:16:34 Rémi Denis-Courmont wrote:
> Le 2014-10-15 16:14, Imran Zaman a écrit :
> > Hi
> >
> > The patch is used to replace strtol and strtoul with wl_strtol and
> > wl_strtoul with inputs and result checks.
>
> I don't know where Wayland developers stand on this, bu
According the the Linux man page you have to set errno to zero to use
strtol correctly anyway.
Quick test shows this is the only way to detect out-of-range errors. The
glib strtol consumes all digits no matter how many you type in (rather
than possibly quitting on the first digit that makes th
2014-10-15 22:01 GMT+03:00 Imran Zaman :
> The reason is that strtol is used at many places in weston/wayland..
> and its not covering all the error cases everywhere.. so its better to
> encapsulate it in a function which i did..
You may have a point here, but imho it must not be an exported
funct
You might be able to remove the base argument, is anybody using that?
That would remove confusion over which is the base and return argument
Also it seems like calling code would be easier to read with a version
that returns the value but puts the error into errno. Something like this:
val
The reason is that strtol is used at many places in weston/wayland..
and its not covering all the error cases everywhere (i.e. its buggy)..
so its better to
encapsulate it in a function with all the input and output checks...
it can be moved to weston if its sound such a big deal...
On Wed, Oct 15
The reason is that strtol is used at many places in weston/wayland..
and its not covering all the error cases everywhere.. so its better to
encapsulate it in a function which i did..
On Wed, Oct 15, 2014 at 9:31 PM, Jasper St. Pierre
wrote:
> Why? What's the rationale for this?
>
> On Wed, Oct 15
I don't see how this belongs in libwayland. Sure, we use strtol twice, but
I don't think that warrants adding 100 lines of wrapper functions and test
cases.
--Jason Ekstrand
On Wed, Oct 15, 2014 at 6:16 AM, Rémi Denis-Courmont
wrote:
> Le 2014-10-15 16:14, Imran Zaman a écrit :
>
>> Hi
>>
>> Th
Why? What's the rationale for this?
On Wed, Oct 15, 2014 at 6:18 AM, Imran Zaman wrote:
> Hi
>
> The patch is used to replace strtol and strtoul with wl_strtol and
> wl_strtoul with inputs and result checks.
>
> The utility functions are used extensively in wayland and weston so added
> appropri
Hi
The patch is used to replace strtol and strtoul with wl_strtol and
wl_strtoul with inputs and result checks.
The utility functions are used extensively in wayland and weston so added
appropriate
input and output checks; test cases are also updated; will push the patch
for weston as well.
Le 2014-10-15 16:14, Imran Zaman a écrit :
Hi
The patch is used to replace strtol and strtoul with wl_strtol and
wl_strtoul with inputs and result checks.
I don't know where Wayland developers stand on this, but I would rather
the client library function calls not clobber errno to zero.
--
Hi
The patch is used to replace strtol and strtoul with wl_strtol and
wl_strtoul with inputs and result checks.
The utility functions are used extensively in wayland and weston so added
appropriate
input and output checks; test cases are also updated; will push the patch
for weston as well.
BR
i
16 matches
Mail list logo
