Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-21 Thread Emil Velikov
On 21 March 2018 at 09:28, Daniel Stone wrote: > Hi, > > On 21 March 2018 at 08:27, Pekka Paalanen wrote: >> On Tue, 20 Mar 2018 11:46:32 +, Daniel Stone >> wrote: >>> inconvenience of maintaining a list of every linker's implementation >>> detail on every platform, outweighs the risk of an

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-21 Thread Daniel Stone
Hi, On 21 March 2018 at 08:27, Pekka Paalanen wrote: > On Tue, 20 Mar 2018 11:46:32 +, Daniel Stone wrote: >> inconvenience of maintaining a list of every linker's implementation >> detail on every platform, outweighs the risk of an exported >> underscore-prefixed symbol slipping through rev

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-21 Thread Pekka Paalanen
On Tue, 20 Mar 2018 11:46:32 + Daniel Stone wrote: > inconvenience of maintaining a list of every linker's implementation > detail on every platform, outweighs the risk of an exported > underscore-prefixed symbol slipping through review. Hi, how about we make it a coding style rule to not h

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 15:09, Derek Foreman wrote: > On 2018-03-20 10:02 AM, Emil Velikov wrote: >> On 20 March 2018 at 14:50, Derek Foreman wrote: >>> On 2018-03-20 07:11 AM, Daniel Stone wrote: On 20 March 2018 at 11:55, Emil Velikov wrote: > On 20 March 2018 at 11:46, Daniel Stone wrot

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Derek Foreman
On 2018-03-20 10:02 AM, Emil Velikov wrote: > On 20 March 2018 at 14:50, Derek Foreman wrote: >> On 2018-03-20 07:11 AM, Daniel Stone wrote: >>> On 20 March 2018 at 11:55, Emil Velikov wrote: On 20 March 2018 at 11:46, Daniel Stone wrote: > Sure. As on IRC though, we definitely need to

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 14:50, Derek Foreman wrote: > On 2018-03-20 07:11 AM, Daniel Stone wrote: >> On 20 March 2018 at 11:55, Emil Velikov wrote: >>> On 20 March 2018 at 11:46, Daniel Stone wrote: Sure. As on IRC though, we definitely need to add at least _ftext for MIPS anyway: htt

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Derek Foreman
On 2018-03-20 07:11 AM, Daniel Stone wrote: > On 20 March 2018 at 11:55, Emil Velikov wrote: >> On 20 March 2018 at 11:46, Daniel Stone wrote: >>> Sure. As on IRC though, we definitely need to add at least _ftext for >>> MIPS anyway: >>> https://gitlab.gnome.org/GNOME/glib/commit/ad12142943e0f20e

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 12:11, Daniel Stone wrote: > On 20 March 2018 at 11:55, Emil Velikov wrote: >> On 20 March 2018 at 11:46, Daniel Stone wrote: >>> Sure. As on IRC though, we definitely need to add at least _ftext for >>> MIPS anyway: >>> https://gitlab.gnome.org/GNOME/glib/commit/ad12142943e0

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Daniel Stone
On 20 March 2018 at 11:55, Emil Velikov wrote: > On 20 March 2018 at 11:46, Daniel Stone wrote: >> Sure. As on IRC though, we definitely need to add at least _ftext for >> MIPS anyway: >> https://gitlab.gnome.org/GNOME/glib/commit/ad12142943e0f20ed9583c9d6bf50f6262110c74 >> >> And probably some m

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 11:46, Daniel Stone wrote: > Hi Emil, > > On 20 March 2018 at 11:30, Emil Velikov wrote: >> On 20 March 2018 at 11:01, Daniel Stone wrote: >>> Rather than a hard-coded list of platform symbols, just ignore anything >>> prefaced with an underscore. This fixes breakage on ARM,

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Daniel Stone
Hi Emil, On 20 March 2018 at 11:30, Emil Velikov wrote: > On 20 March 2018 at 11:01, Daniel Stone wrote: >> Rather than a hard-coded list of platform symbols, just ignore anything >> prefaced with an underscore. This fixes breakage on ARM, which declares >> several slightly different platform sy

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 11:01, Daniel Stone wrote: > Rather than a hard-coded list of platform symbols, just ignore anything > prefaced with an underscore. This fixes breakage on ARM, which declares > several slightly different platform symbols to x86. > FWIW I've explicitly opted against this kind of

[PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Daniel Stone
Rather than a hard-coded list of platform symbols, just ignore anything prefaced with an underscore. This fixes breakage on ARM, which declares several slightly different platform symbols to x86. Signed-off-by: Daniel Stone Fixes: 21b1f22eb056 ("wayland-egl: enhance the symbol test") Bugzilla: ht