Re: [PATCH wayland] wayland-client : Fix queue_release not to call proxy_destroy

2015-08-06 Thread Daniel Stone
Hi, On 31 July 2015 at 10:02, Elvis Lee wrote: > proxy_destroy could be called twice by wl_proxy_destroy and > wl_event_queue_release. > Then, wl_map_remove was called twice for same object id. > > Signed-off-by: Elvis Lee > --- > src/wayland-client.c | 10 ++ > 1 file changed, 6 ins

Re: [PATCH wayland] wayland-client : Fix queue_release not to call proxy_destroy

2015-07-31 Thread Jonas Ådahl
On Fri, Jul 31, 2015 at 02:22:03PM -0700, Bill Spitzak wrote: > On Fri, Jul 31, 2015 at 2:02 AM, Elvis Lee wrote: > > > > > + proxy_destroyed = !!(proxy->flags & > > WL_PROXY_FLAG_DESTROYED); > > + > > + proxy->refcount--; > > + if (proxy_destroyed && !pr

Re: [PATCH wayland] wayland-client : Fix queue_release not to call proxy_destroy

2015-07-31 Thread Bill Spitzak
On Fri, Jul 31, 2015 at 2:02 AM, Elvis Lee wrote: > > + proxy_destroyed = !!(proxy->flags & > WL_PROXY_FLAG_DESTROYED); > + > + proxy->refcount--; > + if (proxy_destroyed && !proxy->refcount) > + free(proxy); > It seems like you don

Re: [PATCH wayland] wayland-client : Fix queue_release not to call proxy_destroy

2015-07-31 Thread Jonas Ådahl
On Fri, Jul 31, 2015 at 06:02:54PM +0900, Elvis Lee wrote: > proxy_destroy could be called twice by wl_proxy_destroy and > wl_event_queue_release. > Then, wl_map_remove was called twice for same object id. > > Signed-off-by: Elvis Lee This looks better to me, thanks. Reviewed-by: Jonas Ådahl

[PATCH wayland] wayland-client : Fix queue_release not to call proxy_destroy

2015-07-31 Thread Elvis Lee
proxy_destroy could be called twice by wl_proxy_destroy and wl_event_queue_release. Then, wl_map_remove was called twice for same object id. Signed-off-by: Elvis Lee --- src/wayland-client.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/wayland-client.c b/