Re: [PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

2016-11-21 Thread Yong Bakos
.c doesn't use it when invoking a wl_dispatcher_func_t. > > yong Here... >> Begin forwarded message: >> >> From: Jason Ekstrand <...> >> Subject: Re: [PATCH wayland] util: Clarify documentation of >> wl_dispatcher_func_t >> Date: November 20,

Re: [PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

2016-11-21 Thread Yong Bakos
Please disregard, need to annotate the v2. Apologies for the noise. y > On Nov 21, 2016, at 5:40 AM, Yong Bakos wrote: > > From: Yong Bakos > > Adjust the brief, clarify the behavior and arguments, correct a grammar > error, document the parameters, and document the return type. > > Signed-

[PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

2016-11-21 Thread Yong Bakos
From: Yong Bakos Adjust the brief, clarify the behavior and arguments, correct a grammar error, document the parameters, and document the return type. Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington --- src/wayland-util.h | 27 +-- 1 file changed, 17 insertions

Re: [PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

2016-11-17 Thread Bryce Harrington
On Thu, Nov 17, 2016 at 08:23:14AM -0800, Yong Bakos wrote: > From: Yong Bakos > > Adjust the brief, clarify the behavior and arguments, correct a grammar > error, and document the parameters. > > Signed-off-by: Yong Bakos Definitely an improvement. The brief still feels a bit heavy on jargon

Re: [PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

2016-11-17 Thread Yong Bakos
On Nov 17, 2016, at 8:23 AM, Yong Bakos wrote: > > From: Yong Bakos > > Adjust the brief, clarify the behavior and arguments, correct a grammar > error, and document the parameters. > > Signed-off-by: Yong Bakos Eh - what is the int return value for? connection.c doesn't use it when invoking

[PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

2016-11-17 Thread Yong Bakos
From: Yong Bakos Adjust the brief, clarify the behavior and arguments, correct a grammar error, and document the parameters. Signed-off-by: Yong Bakos --- src/wayland-util.h | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/src/wayland-util.h b/src