Re: [PATCH wayland] scanner: Reword fallthrough comment to quiet GCC

2017-03-17 Thread Daniel Stone
Hey Yong, On 17 March 2017 at 17:55, Yong Bakos wrote: > This mere comment change seems innocuous enough. > (Should the standard `__attribute__ ((fallthrough))` be used instead?) It could be good, but then we'd need autoconf bits to detect that and come up with a macro for it ... seemed a bit ov

Re: [PATCH wayland] scanner: Reword fallthrough comment to quiet GCC

2017-03-17 Thread Yong Bakos
Hi Daniel, > On Mar 17, 2017, at 10:36 AM, Daniel Stone wrote: > > GCC 7 now requires an explicit comment noting that case statements > without a break fall through. We already had one of those in the > scanner, but GCC wasn't smart enough to pick it up. > > Quiet the warning by making the comm

[PATCH wayland] scanner: Reword fallthrough comment to quiet GCC

2017-03-17 Thread Daniel Stone
GCC 7 now requires an explicit comment noting that case statements without a break fall through. We already had one of those in the scanner, but GCC wasn't smart enough to pick it up. Quiet the warning by making the comment less elaborate. Signed-off-by: Daniel Stone --- src/scanner.c | 4 +---