Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-26 Thread Pekka Paalanen
On Fri, 23 Feb 2018 16:45:14 -0600 Derek Foreman wrote: > Pushed with Daniel's RB. Hi Derek, this seems to have trivially broken 'make check' by not updating the reference output files for wayland-scanner. Thanks, pq > On 2018-02-23 04:39 PM, Daniel Stone wrote: > > Rb me (sorry for mangled

Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-26 Thread Pekka Paalanen
On Fri, 23 Feb 2018 22:46:39 + Emil Velikov wrote: > On 23 February 2018 at 22:24, Derek Foreman wrote: > > Missing a closing bracket. > > > Eek, that's a embarasing. > Reviewed-by: Emil Velikov > > We might want to tweak the existing infra to check that, bonus points > if we also check

Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-23 Thread Emil Velikov
On 23 February 2018 at 22:24, Derek Foreman wrote: > Missing a closing bracket. > Eek, that's a embarasing. Reviewed-by: Emil Velikov We might want to tweak the existing infra to check that, bonus points if we also check the headers actually safe for inclusion in C and C++ sources. A simple runn

Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-23 Thread Derek Foreman
Pushed with Daniel's RB. Thanks, Derek On 2018-02-23 04:39 PM, Daniel Stone wrote: Rb me (sorry for mangled phone client formatting ...) On Fri, 23 Feb 2018, 10:25 pm Derek Foreman, > wrote: Missing a closing bracket. Signed-off-by: Derek Foreman mailt

[PATCH wayland] scanner: Fix broken private-code generation

2018-02-23 Thread Derek Foreman
Missing a closing bracket. Signed-off-by: Derek Foreman --- src/scanner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index c93070c..1737911 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -1748,7 +1748,7 @@ emit_code(struct protocol *proto