Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2017-12-05 Thread Daniel Stone
Hi Pekka, On 9 May 2016 at 12:45, Pekka Paalanen wrote: > The existing specification was not explicitly clear on when > wl_subcompositor.get_subsurface request actually adds the sub-surface to > the parent in the compositor's scenegraph. The implicit assumption was > that this happens immediately

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Yong Bakos
On May 10, 2016, at 3:19 AM, Pekka Paalanen wrote: > > On Mon, 9 May 2016 07:58:32 -0500 > Yong Bakos wrote: > >> Hi Pekka, >> Two minor nits in the description, noted inline below. >> >> yong >> >> On May 9, 2016, at 6:45 AM, Pekka Paalanen wrote: >>> >>> From: Pekka Paalanen >>> >>> The

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Pekka Paalanen
On Tue, 10 May 2016 11:57:00 +0200 Martin Graesslin wrote: > Looks good to me, thanks for addressing this. Hi Martin, I'll record that as a Reviewed-by, then. Thanks, pq > On Monday, May 9, 2016 2:45:05 PM CEST Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > The existing specificati

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Pekka Paalanen
On Tue, 10 May 2016 17:42:59 +0800 Jonas Ådahl wrote: > On Tue, May 10, 2016 at 11:19:29AM +0300, Pekka Paalanen wrote: > > On Mon, 9 May 2016 07:58:32 -0500 > > Yong Bakos wrote: > > > > > Hi Pekka, > > > Two minor nits in the description, noted inline below. > > > > > > yong > > > > > > O

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Martin Graesslin
Looks good to me, thanks for addressing this. Cheers, Martin G. On Monday, May 9, 2016 2:45:05 PM CEST Pekka Paalanen wrote: > From: Pekka Paalanen > > The existing specification was not explicitly clear on when > wl_subcompositor.get_subsurface request actually adds the sub-surface to > the pa

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Jonas Ådahl
On Tue, May 10, 2016 at 11:19:29AM +0300, Pekka Paalanen wrote: > On Mon, 9 May 2016 07:58:32 -0500 > Yong Bakos wrote: > > > Hi Pekka, > > Two minor nits in the description, noted inline below. > > > > yong > > > > On May 9, 2016, at 6:45 AM, Pekka Paalanen wrote: > > > > > > From: Pekka Paa

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Jonas Ådahl
On Tue, May 10, 2016 at 11:27:25AM +0300, Pekka Paalanen wrote: > On Tue, 10 May 2016 11:43:04 +0800 > Jonas Ådahl wrote: > > > On Mon, May 09, 2016 at 02:45:05PM +0300, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > The existing specification was not explicitly clear on when > >

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Pekka Paalanen
On Tue, 10 May 2016 11:43:04 +0800 Jonas Ådahl wrote: > On Mon, May 09, 2016 at 02:45:05PM +0300, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > The existing specification was not explicitly clear on when > > wl_subcompositor.get_subsurface request actually adds the sub-surface to > > t

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Pekka Paalanen
On Mon, 09 May 2016 11:48:07 -0500 Derek Foreman wrote: > On 09/05/16 06:45 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > The existing specification was not explicitly clear on when > > wl_subcompositor.get_subsurface request actually adds the sub-surface to > > the parent in the c

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-10 Thread Pekka Paalanen
On Mon, 9 May 2016 07:58:32 -0500 Yong Bakos wrote: > Hi Pekka, > Two minor nits in the description, noted inline below. > > yong > > On May 9, 2016, at 6:45 AM, Pekka Paalanen wrote: > > > > From: Pekka Paalanen > > > > The existing specification was not explicitly clear on when > > wl_sub

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-09 Thread Jonas Ådahl
On Mon, May 09, 2016 at 02:45:05PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > The existing specification was not explicitly clear on when > wl_subcompositor.get_subsurface request actually adds the sub-surface to > the parent in the compositor's scenegraph. The implicit assumption wa

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-09 Thread Derek Foreman
On 09/05/16 06:45 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > The existing specification was not explicitly clear on when > wl_subcompositor.get_subsurface request actually adds the sub-surface to > the parent in the compositor's scenegraph. The implicit assumption was > that this happen

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-09 Thread Yong Bakos
Hi Pekka, Two minor nits in the description, noted inline below. yong On May 9, 2016, at 6:45 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > The existing specification was not explicitly clear on when > wl_subcompositor.get_subsurface request actually adds the sub-surface to > the par

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-09 Thread Daniel Stone
On 9 May 2016 at 12:45, Pekka Paalanen wrote: > To make setting up a subsurface slightly easier by removing one > possibility for a glitch, this patch amends the specification to require > a wl_surface.commit on the parent surface for get_subsurface to > complete. The sub-surface cannot become map

[PATCH wayland] protocol: make get_subsurface double-buffered

2016-05-09 Thread Pekka Paalanen
From: Pekka Paalanen The existing specification was not explicitly clear on when wl_subcompositor.get_subsurface request actually adds the sub-surface to the parent in the compositor's scenegraph. The implicit assumption was that this happens immediately, but it was not written anywhere. If it h