Re: [PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

2015-11-20 Thread Derek Foreman
On 19/11/15 01:02 AM, Jonas Ådahl wrote: > On Wed, Nov 18, 2015 at 09:44:11AM -0600, Derek Foreman wrote: >> The documentation for wl_surface.commit makes it clear that the >> application of damage follows attach during the commit, so it >> doesn't matter what order the app sends the requests. >> >

Re: [PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

2015-11-19 Thread Derek Foreman
On 19/11/15 12:25 PM, Bill Spitzak wrote: > > > On Thu, Nov 19, 2015 at 3:08 AM, Daniel Stone > wrote: > > Hi, > > On 18 November 2015 at 18:30, Bill Spitzak > wrote: > > On Wed, Nov 18, 2015 at 7:44 AM, Derek Foreman >

Re: [PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

2015-11-19 Thread Bill Spitzak
On Thu, Nov 19, 2015 at 3:08 AM, Daniel Stone wrote: > Hi, > > On 18 November 2015 at 18:30, Bill Spitzak wrote: > > On Wed, Nov 18, 2015 at 7:44 AM, Derek Foreman > > wrote: > >> The documentation for wl_surface.commit makes it clear that the > >> application of damage follows attach during th

Re: [PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

2015-11-19 Thread Daniel Stone
Hi, On 18 November 2015 at 18:30, Bill Spitzak wrote: > On Wed, Nov 18, 2015 at 7:44 AM, Derek Foreman > wrote: >> The documentation for wl_surface.commit makes it clear that the >> application of damage follows attach during the commit, so it >> doesn't matter what order the app sends the reque

Re: [PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

2015-11-18 Thread Jonas Ådahl
On Wed, Nov 18, 2015 at 09:44:11AM -0600, Derek Foreman wrote: > The documentation for wl_surface.commit makes it clear that the > application of damage follows attach during the commit, so it > doesn't matter what order the app sends the requests. > > Many existing apps post damage before attachi

Re: [PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

2015-11-18 Thread Bill Spitzak
On Wed, Nov 18, 2015 at 7:44 AM, Derek Foreman wrote: > The documentation for wl_surface.commit makes it clear that the > application of damage follows attach during the commit, so it > doesn't matter what order the app sends the requests. > > Many existing apps post damage before attaching a buf

[PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

2015-11-18 Thread Derek Foreman
The documentation for wl_surface.commit makes it clear that the application of damage follows attach during the commit, so it doesn't matter what order the app sends the requests. Many existing apps post damage before attaching a buffer already, and it's really quite reasonable to do so. Signed-o