Re: [PATCH wayland] protocol: Add a surface_has_existing_role error

2014-09-22 Thread Jasper St. Pierre
I think it would be a pain to do that, and might not be clear for wl_seat and wl_data_device. If you believe in it, all power to you. On 22 Sep 2014 02:10, "Pekka Paalanen" wrote: > On Mon, 25 Aug 2014 08:59:51 +0300 > Pekka Paalanen wrote: > > > On Fri, 22 Aug 2014 10:48:02 -0700 > > Jason Ekst

Re: [PATCH wayland] protocol: Add a surface_has_existing_role error

2014-09-22 Thread Pekka Paalanen
On Mon, 25 Aug 2014 08:59:51 +0300 Pekka Paalanen wrote: > On Fri, 22 Aug 2014 10:48:02 -0700 > Jason Ekstrand wrote: > > > As I mentioned on IRC, I don't really like adding and using an enum value > > without bumping protocol version. However, the only time we ever use it is > > to kill the c

Re: [PATCH wayland] protocol: Add a surface_has_existing_role error

2014-08-24 Thread Pekka Paalanen
On Fri, 22 Aug 2014 10:48:02 -0700 Jason Ekstrand wrote: > As I mentioned on IRC, I don't really like adding and using an enum value > without bumping protocol version. However, the only time we ever use it is > to kill the client so the worst thing that can happen is that the client > doesn't r

Re: [PATCH wayland] protocol: Add a surface_has_existing_role error

2014-08-22 Thread Jason Ekstrand
As I mentioned on IRC, I don't really like adding and using an enum value without bumping protocol version. However, the only time we ever use it is to kill the client so the worst thing that can happen is that the client doesn't report the error correctly. I think I'm ok with it. --Jason Ekstran

[PATCH wayland] protocol: Add a surface_has_existing_role error

2014-08-22 Thread Jasper St. Pierre
This will be used by implementations to send out errors if clients try to set roles on surfaces that already have roles. --- protocol/wayland.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index bb457bc..f6eb54d 100644 --- a/protocol/wayland.xml