Re: [PATCH wayland] contributing: review rules for bugs

2018-06-28 Thread Pekka Paalanen
On Thu, 28 Jun 2018 10:41:43 +0100 Emil Velikov wrote: > On 28 June 2018 at 10:12, Pekka Paalanen wrote: > > It's the spirit of the guidelines that matters, they are not to be > > interpreted by the letter, and there may always be special > > circumstances where the reasonable action is to over

Re: [PATCH wayland] contributing: review rules for bugs

2018-06-28 Thread Emil Velikov
On 28 June 2018 at 10:12, Pekka Paalanen wrote: > On Wed, 27 Jun 2018 17:49:34 +0100 > Emil Velikov wrote: > >> Hi Pekka, >> >> A couple small ideas come to mind: >> >> On 27 June 2018 at 14:47, Pekka Paalanen wrote: >> > From: Pekka Paalanen >> > >> > Half of the ideas came from Daniel but mos

Re: [PATCH wayland] contributing: review rules for bugs

2018-06-28 Thread Pekka Paalanen
On Wed, 27 Jun 2018 17:49:34 +0100 Emil Velikov wrote: > Hi Pekka, > > A couple small ideas come to mind: > > On 27 June 2018 at 14:47, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Half of the ideas came from Daniel but most of them are reworded, the > > rest are my thoughts. > > >

Re: [PATCH wayland] contributing: review rules for bugs

2018-06-27 Thread Emil Velikov
Hi Pekka, A couple small ideas come to mind: On 27 June 2018 at 14:47, Pekka Paalanen wrote: > From: Pekka Paalanen > > Half of the ideas came from Daniel but most of them are reworded, the > rest are my thoughts. > > Mention compiler warnings specifically, and be more explicit on what > kind o

Re: [PATCH wayland] contributing: review rules for bugs

2018-06-27 Thread Pekka Paalanen
On Wed, 27 Jun 2018 16:47:09 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Half of the ideas came from Daniel but most of them are reworded, the > rest are my thoughts. > > Mention compiler warnings specifically, and be more explicit on what > kind of code or bugs or bug fixes are acc

[PATCH wayland] contributing: review rules for bugs

2018-06-27 Thread Pekka Paalanen
From: Pekka Paalanen Half of the ideas came from Daniel but most of them are reworded, the rest are my thoughts. Mention compiler warnings specifically, and be more explicit on what kind of code or bugs or bug fixes are acceptable or not. Clarify commit scope. Cc: Daniel Stone Signed-off-by: P