Re: [PATCH wayland] connection: Don't write past the end of the connection buffer

2014-04-21 Thread Kristian Høgsberg
On Thu, Apr 17, 2014 at 06:20:37PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > If a message was too big to fit in the connection buffer, the code > in wl_buffer_put would just write past the end of it. > > I haven't seen any real world use case that would tr

Re: [PATCH wayland] connection: Don't write past the end of the connection buffer

2014-04-17 Thread Jason Ekstrand
On Apr 17, 2014 10:37 AM, "Hardening" wrote: > > Le 17/04/2014 17:20, Ander Conselvan de Oliveira a écrit : > >> From: Ander Conselvan de Oliveira >> >> If a message was too big to fit in the connection buffer, the code >> in wl_buffer_put would just write past the end of it. >> >> I haven't seen

Re: [PATCH wayland] connection: Don't write past the end of the connection buffer

2014-04-17 Thread Hardening
Le 17/04/2014 17:20, Ander Conselvan de Oliveira a écrit : From: Ander Conselvan de Oliveira If a message was too big to fit in the connection buffer, the code in wl_buffer_put would just write past the end of it. I haven't seen any real world use case that would trigger this bug, but it was p

Re: [PATCH wayland] connection: Don't write past the end of the connection buffer

2014-04-17 Thread Jasper St. Pierre
On Thu, Apr 17, 2014 at 11:20 AM, Ander Conselvan de Oliveira < conselv...@gmail.com> wrote: > From: Ander Conselvan de Oliveira > > If a message was too big to fit in the connection buffer, the code > in wl_buffer_put would just write past the end of it. > > I haven't seen any real world use cas

[PATCH wayland] connection: Don't write past the end of the connection buffer

2014-04-17 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If a message was too big to fit in the connection buffer, the code in wl_buffer_put would just write past the end of it. I haven't seen any real world use case that would trigger this bug, but it was possible to trigger it by sending a long enough string to the