Re: [PATCH wayland] add wl_abort private function

2015-11-16 Thread Bryce Harrington
On Mon, Nov 16, 2015 at 02:01:20PM -0600, Derek Foreman wrote: > On 16/11/15 04:49 AM, Marek Chalupa wrote: > > On many places in the code we use wl_log + abort or wl_log + assert(0). > > Replace these with one call to wl_abort, so that we don't mix abort(), > > assert(0) and we'll save few lines >

Re: [PATCH wayland] add wl_abort private function

2015-11-16 Thread Derek Foreman
On 16/11/15 04:49 AM, Marek Chalupa wrote: > On many places in the code we use wl_log + abort or wl_log + assert(0). > Replace these with one call to wl_abort, so that we don't mix abort(), > assert(0) and we'll save few lines > > Signed-off-by: Marek Chalupa Sure, I think this looks cleaner tha

Re: [PATCH wayland] add wl_abort private function

2015-11-16 Thread Bill Spitzak
This sure looks correct to me. Using assert(0) seems like it was a mistake, as it would not happen if NDEBUG was defined but it appears the code is relying on it. And since it was already doing a call to wl_log no overhead was reduced by the removal. On Mon, Nov 16, 2015 at 2:49 AM, Marek Chalup

[PATCH wayland] add wl_abort private function

2015-11-16 Thread Marek Chalupa
On many places in the code we use wl_log + abort or wl_log + assert(0). Replace these with one call to wl_abort, so that we don't mix abort(), assert(0) and we'll save few lines Signed-off-by: Marek Chalupa --- src/connection.c | 22 +++--- src/wayland-client.c | 12 ---