Re: [PATCH v7 weston 17/17] input: Don't test keyboard/pointer/touch pointers

2015-07-31 Thread Bryce Harrington
On Thu, Jul 30, 2015 at 09:40:56AM +0800, Jonas Ådahl wrote: > On Wed, Jul 15, 2015 at 01:00:48PM -0500, Derek Foreman wrote: > > Keyboards and pointers aren't freed when devices are removed, so we should > > really be testing keyboard_device_count and pointer_device_count in most > > cases, not th

Re: [PATCH v7 weston 17/17] input: Don't test keyboard/pointer/touch pointers

2015-07-29 Thread Jonas Ådahl
On Wed, Jul 15, 2015 at 01:00:48PM -0500, Derek Foreman wrote: > Keyboards and pointers aren't freed when devices are removed, so we should > really be testing keyboard_device_count and pointer_device_count in most > cases, not the actual pointers. Otherwise we end up with different > behaviour aft

[PATCH v7 weston 17/17] input: Don't test keyboard/pointer/touch pointers

2015-07-15 Thread Derek Foreman
Keyboards and pointers aren't freed when devices are removed, so we should really be testing keyboard_device_count and pointer_device_count in most cases, not the actual pointers. Otherwise we end up with different behaviour after removing a device than we had before it was inserted. This commit r