Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-19 Thread Jan Arne Petersen
Hi, On 18/02/16 20:36, Rui Tiago Cação Matos wrote: > On Wed, Feb 17, 2016 at 6:13 AM, Jan Arne Petersen wrote: + > ... + + + + >>> >>> These arguments could, and perhaps should, all be type="uint" >> >> Yes I guess for width/height. > > As Jo

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-18 Thread Jonas Ådahl
On Thu, Feb 18, 2016 at 08:36:38PM +0100, Rui Tiago Cação Matos wrote: > On Wed, Feb 17, 2016 at 6:13 AM, Jan Arne Petersen wrote: > >>> + > ... > >>> + > >>> + > >>> + > >>> + > >> > >> These arguments could, and perhaps should, all be type="uint" > > > > Yes I guess f

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-18 Thread Rui Tiago Cação Matos
On Wed, Feb 17, 2016 at 6:13 AM, Jan Arne Petersen wrote: >>> + ... >>> + >>> + >>> + >>> + >> >> These arguments could, and perhaps should, all be type="uint" > > Yes I guess for width/height. As Jonas pointed out, just leave them as "int". One thing I now noticed is

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-16 Thread Jonas Ådahl
On Wed, Feb 17, 2016 at 06:13:00AM +0100, Jan Arne Petersen wrote: > Hi, > > On 08/02/16 16:38, Rui Tiago Cação Matos wrote: > > Hi, > > > > Thanks for the update. I'm replying to both v4 and your reply to my > > previous mail. Inline: > > > > On Tue, Feb 2, 2016 at 2:33 PM, Jan Arne Petersen

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-16 Thread Jan Arne Petersen
Hi, On 08/02/16 16:38, Rui Tiago Cação Matos wrote: > Hi, > > Thanks for the update. I'm replying to both v4 and your reply to my > previous mail. Inline: > > On Tue, Feb 2, 2016 at 2:33 PM, Jan Arne Petersen wrote: >> + >> + >> + Disable text input in a surface (typically whe

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-09 Thread Bill Spitzak
On Mon, Feb 8, 2016 at 7:38 AM, Rui Tiago Cação Matos wrote: > > > + > > + > > + Sets the cursor outline as a rectangle relative to the surface. > > + > > + Allows the compositor to put a window with word suggestions near > the > > + cursor. > > + > > + > >

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-09 Thread Bill Spitzak
Yes that is exactly what I expect. The input method may, if it wants, clamp the region to the surface, or even to the input area of the surface. It does not have to put it disconnected from the visible area like you are showing, though it can if it wants. On Mon, Feb 8, 2016 at 10:42 AM, Rui Tiag

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-08 Thread Rui Tiago Cação Matos
On Mon, Feb 8, 2016 at 7:07 PM, Bill Spitzak wrote: > The x and y have to be signed. Imagine if the client is scrolled in such a > way that the cursor rectangle is partially outside the surface. Are you saying this is an acceptable case: ++ |compositor popup| ++

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-08 Thread Rui Tiago Cação Matos
Hi, Thanks for the update. I'm replying to both v4 and your reply to my previous mail. Inline: On Tue, Feb 2, 2016 at 2:33 PM, Jan Arne Petersen wrote: > + > + > + Disable text input in a surface (typically when there is no focus on > any > + text entry inside the surface)

[PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
There were some shortcomings in the first version of the protocol which makes it not really useful in real world applications. It is not really possible to fix them in a compatible way so introduce a new v2 of the protocol. Fixes some shortcomings of the first version: * Use only one wp_text_inpu