Re: [PATCH v4] Fixes CJK wide character display

2013-08-19 Thread Daniel Stone
Hi, On 19 August 2013 23:37, Kristian Høgsberg wrote: > On Mon, Aug 19, 2013 at 01:00:52PM -0700, Othman, Ossama wrote: >> That's an implementation-specific preprocessor symbol. Please use the >> _XOPEN_SOURCE feature test macro instead. >> >> The user could also potentially define that feature

Re: [PATCH v4] Fixes CJK wide character display

2013-08-19 Thread Kristian Høgsberg
On Mon, Aug 19, 2013 at 01:00:52PM -0700, Othman, Ossama wrote: > Hi, > > CCing the list this time around ... > > On Sun, Aug 18, 2013 at 7:59 PM, Peng Wu wrote: > > > By jumping two columns when wide character prints, > > and draw wide background under wide character. > > --- > > clients/term

Re: [PATCH v4] Fixes CJK wide character display

2013-08-19 Thread Othman, Ossama
Hi, CCing the list this time around ... On Sun, Aug 18, 2013 at 7:59 PM, Peng Wu wrote: > By jumping two columns when wide character prints, > and draw wide background under wide character. > --- > clients/terminal.c | 31 +-- > 1 file changed, 29 insertions(+), 2 d

[PATCH v4] Fixes CJK wide character display

2013-08-18 Thread Peng Wu
By jumping two columns when wide character prints, and draw wide background under wide character. --- clients/terminal.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/clients/terminal.c b/clients/terminal.c index 6701fb6..9da1a56 100644 --- a/

[PATCH v4] Fixes CJK wide character display

2013-08-18 Thread Peng Wu
Hi, I used ZERO WIDTH SPACE(U+200B) as the invalid UTF-8 character, also ignore these filler cells in terminal_send_selection. Please review it again, thanks. Peng Wu (1): Fixes CJK wide character display clients/terminal.c | 31 +-- 1 file changed, 29 insertio